Don't notify crossgen2 about Vector<T> size when not needed#34614
Merged
davidwrighton merged 1 commit intodotnet:masterfrom Apr 30, 2020
Merged
Conversation
Member
davidwrighton
commented
Apr 6, 2020
davidwrighton
commented
- Stop notifying about usage status of AVX2 when using isSubRegisterSIMDType
- This allows use of the Vector2/3/4 simd types in crossgen'd code without fixing whether or not Avx2 is required
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
Member
Author
|
@CarolEidt This is the issue I fixed conservatively before checking in my large hardware instrinsics pr(#33274 ). |
- Stop notifying about usage status of AVX2 when using isSubRegisterSIMDType - This allows use of the Vector2/3/4 simd types in crossgen'd code without fixing whether or not Avx2 is required
davidwrighton
force-pushed
the
moreOpportunisticHandlingOfSubRegisterOps
branch
from
2eda040 to
51a0fab
Compare
Member
Author
|
I held off on checking this in waiting for good crossgen2 CI infrastructure to be put together. Now that we have it, its clear that the fix is good, and I'm checking in. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.