Fix compilation of System.Net.Security.Native on Linux#34018
Fix compilation of System.Net.Security.Native on Linux#34018akoeplinger merged 1 commit intodotnet:masterfrom
Conversation
It was accidentally moved to a OSX/iOS-only conditional in dotnet#33970 but it should be built on Linux too.
It's certainly possible that all of our negotiate-related tests are outer loop. @davidsh? In the future we should run outer loop tests on anything like this that impacts System.Net, as there's a fair amount of validation done in outer loop that's not done in inner loop, at least today. |
Linux specific ones are part of the 'runtime-libraries enterprise-linux' pipeline. It is neither innerloop or outerloop but a separate pipeline. It runs all the time for every PR but only those PRs that touch System.Net code. But this problem described here sounds like a compilation error which should have been caught in the regular CI validation. |
|
@davidsh I see. The PR only touched the CMakeLists.txt file but not any of the source files so the pipeline didn't get triggered: There were no compilation errors since building of the library was simply skipped. |
It was accidentally moved to a OSX/iOS-only conditional in #33970 but it should be built on Linux too.
@stephentoub any idea why this was green in #33970? are the tests which rely on System.Net.Security.Native only run in outerloop?