Fixed heap corruption in HttpListener#33110
Merged
ManickaP merged 1 commit intodotnet:masterfrom Mar 3, 2020
Merged
Conversation
Member
Author
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MihaZupan
approved these changes
Mar 3, 2020
karelz
approved these changes
Mar 3, 2020
…e even in multi-threaded and multiple Dispose calls.
ManickaP
force-pushed
the
mapichov/31997_heap_corruption
branch
from
b89c8fd to
cfcb23d
Compare
Member
Author
|
Test failures seem unrelated, can be seen on other PRs as well. Might be fixed with #32827, so rebasing on current master and we'll see. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31997
In non-blocking
HttpListenerResponse.Close,RequestContextBasewas being disposed multiple times from different threads. This fix ensures that the underlyingIntPtris freed only once, even in multi-threaded scenarios.Full explanation here: #31997 (comment)