Pass native build args from top-level scripts#2071
Merged
janvorli merged 7 commits intodotnet:masterfrom Jan 30, 2020
am11:feature/consolidations
Merged
Pass native build args from top-level scripts#2071janvorli merged 7 commits intodotnet:masterfrom am11:feature/consolidations
janvorli merged 7 commits intodotnet:masterfrom
am11:feature/consolidations
Conversation
This was referenced Jan 23, 2020
am11
commented
Jan 23, 2020
| <_CoreClrBuildArg Include="-$(Configuration.ToLower())" /> | ||
| <_CoreClrBuildArg Include="$(Compiler)" /> | ||
| <_CoreClrBuildArg Condition="'$(ContinuousIntegrationBuild)' == 'true'" Include="-ci" /> | ||
| <_CoreClrBuildArg Condition="'$(CrossBuild)' == 'true'" Include="-cross" /> |
Member
Author
There was a problem hiding this comment.
[IMO]
Now that all native build scripts share common arguments via:
runtime/eng/native/build-commons.sh
Lines 160 to 194 in e2325f3
coreclr/coreclr.proj, installer/corehost/build.proj and libraries/Native/build-native.proj into a common .props file, to avoid three different approaches of doing exactly the same thing (coreclr: ItemGroup, installer: property concatenation and libraries: separate properties followed by concatenation).
Member
There was a problem hiding this comment.
Member
Author
|
@janvorli, could you please give it a pass? |
janvorli
reviewed
Jan 29, 2020
janvorli
reviewed
Jan 30, 2020
Member
|
@am11 thank you for spending time to figure out a cleaner solution to the problem of passing the argument with spaces. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ability to pass
--cross,--clangx.y,--gccx.yand--cmakeargsto native scripts via top-levelbuild.sh. e.g.Also address CR feedback from PRs #1753 and #1602 (in separate commits).