Refactor CMake system to allow cross OS DAC compile#2054
Merged
sdmaclea merged 2 commits intodotnet:masterfrom Jan 24, 2020
Merged
Refactor CMake system to allow cross OS DAC compile#2054sdmaclea merged 2 commits intodotnet:masterfrom
sdmaclea merged 2 commits intodotnet:masterfrom
Conversation
Contributor
Author
Member
|
Currently |
Member
|
The build break on musl is likely introduced by these changes. Could you please take a look? |
Add CLR_CMAKE_HOST_OS Add rules to determine which cross OS combinations are valid Make add_defintions depend on TARGET OS properties Wherever reasonable make C++ define defintions depend on runtime target rather than host.
Contributor
Author
|
Thanks @jkotas. I found the error. I neglected to set |
jkotas
approved these changes
Jan 24, 2020
hoyosjs
approved these changes
Jan 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CLR_CMAKE_HOST_OS
Add rules to determine which cross OS combinations are valid
Make add_defintions depend on TARGET OS properties
Wherever reasonable make C++ define defintions depend on runtime target
rather than host.