Skip to content

Backport XML documentation for CustomReflectionContext#124365

Open
Copilot wants to merge 7 commits intomainfrom
copilot/backport-customreflectioncontext-docs
Open

Backport XML documentation for CustomReflectionContext#124365
Copilot wants to merge 7 commits intomainfrom
copilot/backport-customreflectioncontext-docs

Conversation

Copy link
Contributor

Copilot AI commented Feb 13, 2026

Description

Backports XML documentation from dotnet-api-docs to the runtime repository per #124227.

Changes:

  • Added XML documentation to CustomReflectionContext class in src assembly with summary and simplified type-level remarks
  • Added summary, param/return documentation, and short member-level remarks to all public/protected members in src assembly
  • Type-level remarks in src include only a link to supplemental documentation: https://github.com/dotnet/docs/raw/main/docs/fundamentals/runtime-libraries/system-reflection-context-customreflectioncontext.md
  • Member-level remarks provide brief contextual information (e.g., usage guidance for AddProperties and CreateProperty methods)
  • Removed UseCompilerGeneratedDocXmlFile=false from csproj to enable compiler-generated XML documentation files
  • Added <NoWarn>$(NoWarn);CS1591</NoWarn> to suppress missing XML documentation warnings in generated platform-not-supported stubs
  • Ref assembly contains no XML documentation per established guidelines

Customer Impact

Developers using System.Reflection.Context will have IntelliSense documentation with summaries, parameter descriptions, and brief contextual remarks for all members, plus a link to comprehensive documentation showing how to customize reflection behavior through attribute manipulation and virtual properties.

Regression

No. Documentation-only change.

Testing

  • Built successfully for all target frameworks (netstandard2.0, netstandard2.1, net10.0)
  • XML documentation compiles without errors
  • Compiler-generated XML documentation files are created successfully from src assembly
  • Code review passed

Risk

Minimal. Documentation-only change with no runtime impact.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits February 13, 2026 01:09
Co-authored-by: gewarren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: gewarren <24882762+gewarren@users.noreply.github.com>
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Copilot AI changed the title [WIP] Backport documentation for CustomReflectionContext Backport XML documentation for CustomReflectionContext Feb 13, 2026
Copilot AI requested a review from gewarren February 13, 2026 01:15
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Please respond to feedback.

… src remarks

Co-authored-by: gewarren <24882762+gewarren@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 13, 2026

@copilot Please respond to feedback.

Addressed all feedback in commit 865415d:

  • Removed all XML documentation from the ref assembly
  • Simplified the src file remarks to only include the supplemental docs link
  • Removed detailed remarks from member methods
  • Restored UseCompilerGeneratedDocXmlFile=false to prevent CS1591 errors

Co-authored-by: gewarren <24882762+gewarren@users.noreply.github.com>
Copilot AI requested a review from gewarren February 13, 2026 01:36
@gewarren gewarren marked this pull request as ready for review February 13, 2026 04:09
Copilot AI review requested due to automatic review settings February 13, 2026 04:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR backports XML documentation from dotnet-api-docs to the runtime repository for the CustomReflectionContext class, following the established pattern from PR #124227. The documentation provides IntelliSense support for developers using this reflection API.

Changes:

  • Added comprehensive XML documentation to CustomReflectionContext class including type-level summary, simplified remarks with a link to supplemental documentation, and complete member-level documentation
  • All public and protected members now have summaries, parameter descriptions, return value documentation, and brief contextual remarks where appropriate
  • Followed the established convention of not adding documentation to ref assemblies

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Please update the .csproj file to use the compiler generated docs.

Co-authored-by: gewarren <24882762+gewarren@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 13, 2026

@copilot Please update the .csproj file to use the compiler generated docs.

Updated the .csproj to use compiler-generated docs in commit ca89848. Also added minimal XML documentation to the ref assembly to prevent CS1591 errors in the generated netstandard2.0 platform-not-supported stub.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot please remove docs from ref assembly but keep changes to .csproj file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed XML docs from the ref assembly in commit 6c60cb8. Kept the .csproj change (no UseCompilerGeneratedDocXmlFile=false) and added NoWarn for CS1591 to suppress missing XML doc warnings in the generated netstandard2.0 platform-not-supported stub.

Co-authored-by: gewarren <24882762+gewarren@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants