Re-enable symbol stripping for Apple platforms#124266
Open
kotlarmilos wants to merge 4 commits intodotnet:mainfrom
Open
Re-enable symbol stripping for Apple platforms#124266kotlarmilos wants to merge 4 commits intodotnet:mainfrom
kotlarmilos wants to merge 4 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR re-enables symbol stripping for Apple platforms by removing a temporary workaround that was added in PR #123386. The workaround disabled symbol stripping (StripSymbols=false) to avoid dsymutil module cache errors that occurred when Swift code was compiled with -g (full debug info). Now that the underlying Swift compilation has been fixed to use -gline-tables-only instead, symbol stripping can be safely re-enabled.
Changes:
- Removes
StripSymbols=falseworkaround from three .csproj files (ILCompiler, crossgen2, and XUnitLogChecker) - Adds symbol stripping logic to the CrossGen2 test script for Apple mobile runtime tests
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/coreclr/tools/aot/ILCompiler/ILCompiler_publish.csproj | Removes the StripSymbols=false workaround, allowing default symbol stripping behavior to apply |
| src/coreclr/tools/aot/crossgen2/crossgen2_publish.csproj | Removes the StripSymbols=false workaround, allowing default symbol stripping behavior to apply |
| src/tests/Common/XUnitLogChecker/XUnitLogChecker.csproj | Removes the StripSymbols=false workaround, allowing default symbol stripping behavior to apply |
| src/tests/Common/CLRTest.CrossGen.targets | Adds symbol stripping command after linking for Mach-O format outputs when StripSymbols is true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables stripping in ILCompiler_publish.csproj and crossgen2_publish.csproj, introduced in #123386. This should work because Swift compilation in native packs uses -gline-tables-only instead of -g.
Additionally, it adds a stripping command for runtime Apple mobile tests.
Fixes #123687