Fix mixed mode debugging for PInvoke by adding PInvokeStubManager

[Copilot]

Description

PR #117901 changed PInvoke ILStub code to return PInvokeMethodDesc directly from ExecutionManager::GetCodeMethodDesc() instead of DynamicMethodDesc. This broke mixed mode debugger step-in for PInvoke calls because ILStubManager::CheckIsStub_Internal() only checked pMD->IsILStub(), which returns false for PInvokeMethodDesc.

Changes

Implemented a dedicated PInvokeStubManager to handle PInvoke stubs directly:

• stubmgr.h: Added PInvokeStubManager class extending StubManager

  • CheckIsStub_Internal(): Recognizes PInvoke stubs by checking pMD->IsPInvoke()
  • DoTraceStub(): Traces to the native target via PInvokeMethodDesc::GetPInvokeTarget()

• stubmgr.cpp: Implemented PInvokeStubManager methods

  • Init(): Registers the stub manager during system initialization
  • Proper DAC support with DoEnumMemoryRegions()

• appdomain.cpp: Added PInvokeStubManager::Init() call during system domain initialization

• vptr_list.h: Added VPTR_CLASS(PInvokeStubManager) for vtable support

• method.hpp: Added IsInteropStub() helper method

  • Returns true for both IL stubs (IsILStub()) and PInvoke methods (IsPInvoke())
  • Simplifies code that needs to check for interop method calls

• controller.cpp, frameinfo.cpp: Updated debugger code to use IsInteropStub()

  • Replaced 4 occurrences of IsILStub() || IsPInvoke() with cleaner IsInteropStub() calls
  • Renamed fIsILStub variable to fIsInteropStub to accurately reflect that it checks for interop stubs (both IL stubs and PInvoke methods)
  • Makes the codebase more maintainable and easier to understand

This approach handles PInvokeMethodDesc directly without requiring a reverse mapping to DynamicMethodDesc, making it work for both JIT-compiled and R2R (ReadyToRun) PInvoke stubs.

Testing

Built CoreCLR successfully. The PInvokeStubManager is registered at startup and properly integrates with the debugger's stub manager infrastructure to handle all PInvoke stub recognition and tracing. The new IsInteropStub() helper method provides a consistent API for identifying interop stubs throughout the codebase.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>[Bug] Mixed mode debugging step-in not working through some PInvoke calls</issue_title>
<issue_description>For a PInvoke method, there are two separate MethodDescs created:

• A PInvokeMethodDesc which is created from the metadata and holds a pointer to the native code target IP (once it is initialized)
• A DynamicMethodDesc (PInvoke ILStub) which is created by the JIT when the JIT generates the stub that calls into the native method.

Prior to #117901, the DynamicMethodDesc would point to the native ILStub and the ILStub codepointers could lookup the DynamicMethodDesc using EECodeInfo infrastructure. If needed, the PInvokeMethodDesc could be found using the resolver on the DynamicMethodDesc.

After the changes (relevant diff), the ILStub codepointers were modified to lookup the PInvokeMethodDesc directly. While this simplifies finding the PInvokeMethodDesc, this causes the ILStubManager to no longer recognize the code as an ILStub. In turn the debugger treats the method as a normal managed code instead of a stub.

One possible solution would be to map the PInvokeMethodDesc back to the DynamicMethodDesc and add support to the ILStubManager for this scenario. There may be other places in the diagnostics which will need to be updated.</issue_description>

<agent_instructions>Create a solution for this issue using the approach recommended. The PInvokeMethodDesc should have a slot to map back to the DynamicMethodDesc if it has been created. This can be done when the code is patched in codeman.cpp.

Additionally, update ILStubManager to support this type of methoddesc.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

• Fixes [Bug] Mixed mode debugging step-in not working through some PInvoke calls #123410

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[max-charlamb]

@copilot , update the PR title and summary to reflect the new changes. Instead of connecting the ILStubMethodDesc to the PInvokeStub, I implemented a PInvokeStubManager to handle this special PInvokeMethodDesc which points to an ILStub.

[Copilot]

@copilot , update the PR title and summary to reflect the new changes. Instead of connecting the ILStubMethodDesc to the PInvokeStub, I implemented a PInvokeStubManager to handle this special PInvok...

Updated the PR title and description to accurately reflect the PInvokeStubManager implementation. The new approach handles PInvokeMethodDesc directly, which works for both JIT and R2R scenarios.

[max-charlamb]

@copilot , there are now several spots where we want to check if the MethodDesc corresponds to an "interop method call" including if md->IsILStub() or if imd->IsPInvoke(). Can you implement a new method on MethodDesc IsInteropStub() that returns true in either of these conditions.

Then we can simplify the code diff to utilize this option when applicable.

[Copilot]

@copilot , there are now several spots where we want to check if the MethodDesc corresponds to an "interop method call" including if md->IsILStub() or if imd->IsPInvoke(). Can you implement a new ...

Implemented IsInteropStub() method in commit 2cdf2c7. The method returns true for both IL stubs and PInvoke methods, and I've updated all the debug code locations that were checking both conditions to use this new helper method.

[jkotas]

Assuming you have tested that the stepping works fine for both JIT and R2R code with this fix.

[max-charlamb]

@copilot , address feedback

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.