[wasm][coreclr] WIP runtime tests on CI by radekdoulik · Pull Request #123377 · dotnet/runtime

radekdoulik · 2026-01-20T12:56:15Z

TODO

update windows scripts to run on node too
make it run on CI
make it pass on CI, create issues for remaining crashes

Set `isTailcall` to `false`, when preparing the call. This is similar to how we set other state vars for the call, so I did it this way. Alternatively we can reset the `isTailcall` after updating the stack and frame for tailcalls. That would invalidate the meaning of the variable for the rest of the tailcall though, so we would need to rename it at least to signal, that it is valid only in the beginning of the tailcall.

Based on changes from the previous branch (https://github.com/radekdoulik/runtime/tree/clr-wasm-runtime-tests-with-node)

radekdoulik · 2026-01-20T15:09:39Z

/azp run runtime

azure-pipelines · 2026-01-20T15:10:03Z

Azure Pipelines failed to run 1 pipeline(s).

…hecked job

src/tests/JIT/Directed/Misc/function_pointer/MutualThdRecur-fptr.il

jkoritzinsky · 2026-01-21T21:41:13Z

src/tests/Common/mergedrunner.targets

  </Target>

-  <Import Project="$(RepoRoot)/src/tests/Common/mergedrunnermobile.targets" Condition="'$(TargetsMobile)' == 'true' and '$(CLRTestKind)' != 'SharedLibrary'" />
+  <Import Project="$(RepoRoot)/src/tests/Common/mergedrunnermobile.targets" Condition="'$(TargetsMobile)' == 'true' and '$(CLRTestKind)' != 'SharedLibrary'  and ('$(TargetArchitecture)' != 'wasm' or '$(RuntimeFlavor)' != 'CoreCLR')" />


I assume that this will be removed once the CI integration work is done. If not, we should figure out what needs to change here (we want to be on the same tooling as the libraries tests, when possible, to help reduce cost of maintaining this test tree).

The intention here is to be as close to the desktop runtime tests as possible, to keep the tests simple to debug, with minimal added complexity.

…on (dotnet#123215) Fixes dotnet#122923

…s' into clr-wasm-runtime-tests-on-node-2

This reverts commit af6321d.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 58 out of 59 changed files in this pull request and generated 1 comment.

Copilot · 2026-02-12T10:02:20Z

src/tests/run.cmd

 if /i "%1" == "x64"                                     (set __BuildArch=x64&shift&goto Arg_Loop)
 if /i "%1" == "x86"                                     (set __BuildArch=x86&shift&goto Arg_Loop)
 if /i "%1" == "arm64"                                   (set __BuildArch=arm64&shift&goto Arg_Loop)

 if /i "%1" == "debug"                                   (set __BuildType=Debug&shift&goto Arg_Loop)
 if /i "%1" == "release"                                 (set __BuildType=Release&shift&goto Arg_Loop)
 if /i "%1" == "checked"                                 (set __BuildType=Checked&shift&goto Arg_Loop)

 if /i "%1" == "TestEnv"                                 (set __TestEnv=%2&shift&shift&goto Arg_Loop)
 if /i "%1" == "sequential"                              (set __Sequential=1&shift&goto Arg_Loop)
 if /i "%1" == "parallel"                                (set __ParallelType=%2&shift&shift&goto Arg_Loop)
 if /i "%1" == "jitstress"                               (set DOTNET_JitStress=%2&shift&shift&goto Arg_Loop)
 if /i "%1" == "jitstressregs"                           (set DOTNET_JitStressRegs=%2&shift&shift&goto Arg_Loop)
 if /i "%1" == "jitminopts"                              (set DOTNET_JITMinOpts=1&shift&goto Arg_Loop)
 if /i "%1" == "jitforcerelocs"                          (set DOTNET_ForceRelocs=1&shift&goto Arg_Loop)

 if /i "%1" == "printlastresultsonly"                    (set __PrintLastResultsOnly=1&shift&goto Arg_Loop)
 if /i "%1" == "logsdir"                                 (set LogsDirArg=%2&shift&shift&goto Arg_Loop)
 if /i "%1" == "runcrossgen2tests"                       (set RunCrossGen2=1&shift&goto Arg_Loop)
 REM This test feature is currently intentionally undocumented
 if /i "%1" == "runlargeversionbubblecrossgen2tests"     (set RunCrossGen2=1&set CrossgenLargeVersionBubble=1&shift&goto Arg_Loop)
 if /i "%1" == "synthesizepgo"                           (set CrossGen2SynthesizePgo=1&shift&goto Arg_Loop)
 if /i "%1" == "gcname"                                  (set DOTNET_GCName=%2&shift&shift&goto Arg_Loop)
 if /i "%1" == "gcstresslevel"                           (set DOTNET_GCStress=%2&set __TestTimeout=1800000&shift&shift&goto Arg_Loop)
 if /i "%1" == "gcsimulator"                             (set __GCSimulatorTests=1&shift&goto Arg_Loop)
 if /i "%1" == "longgc"                                  (set __LongGCTests=1&shift&goto Arg_Loop)
 if /i "%1" == "ilasmroundtrip"                          (set __IlasmRoundTrip=1&shift&goto Arg_Loop)
 if /i "%1" == "timeout"                                 (set __TestTimeout=%2&shift&shift&goto Arg_Loop)
 if /i "%1" == "runincontext"                            (set RunInUnloadableContext=1&shift&goto Arg_Loop)
 if /i "%1" == "tieringtest"                             (set TieringTest=1&shift&goto Arg_Loop)
 if /i "%1" == "runnativeaottests"                       (set RunNativeAot=1&shift&goto Arg_Loop)
 if /i "%1" == "interpreter"                             (set RunInterpreter=1&shift&goto Arg_Loop)
+if /i "%1" == "node"                                    (set RunWithNodeJS=1&shift&goto Arg_Loop)



run.cmd documents and parses a node switch, but this script currently has no way to target the wasm architecture (wasm) or the browser OS (browser) the way run.sh does. As written, --node can’t be used to run the intended browser/wasm scenarios. Consider adding argument handling for wasm (arch) and browser (OS), and defaulting to browser when __BuildArch==wasm (similar to run.sh).

…n windows

Copilot

Pull request overview

Copilot reviewed 58 out of 59 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 58 out of 59 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/tests/JIT/Directed/Misc/function_pointer/MutualThdRecur-fptr.il:13

This IL file now declares the same extern assemblies multiple times (e.g. Microsoft.DotNet.XUnitExtensions, System.Runtime, TestLibrary). ILAsm typically treats duplicate .assembly extern declarations as an error. Please remove the duplicates or keep a single consolidated set of extern references at the top of the file.

Copilot · 2026-02-12T13:31:31Z

src/tests/Common/helixpublishwitharcade.proj

+    <TargetsBrowserOnMono>false</TargetsBrowserOnMono>
+    <TargetsBrowserOnMono Condition="'$(TargetsBrowser)' == 'true' and '$(RuntimeFlavor)' == 'mono'">true</TargetsBrowserOnMono>
+    <TargetsBrowserOnCoreCLR>false</TargetsBrowserOnCoreCLR>
+    <TargetsBrowserOnCoreCLR Condition="'$(TargetsBrowser)' == 'true' and '$(RuntimeFlavor)' == 'coreclr'">true</TargetsBrowserOnCoreCLR>
+    <TargetsMobile Condition="'$(TargetsBrowser)' == 'true' and '$(RuntimeFlavor)' == 'coreclr'">false</TargetsMobile>
    <MobileAppBundleDirName Condition="'$(TargetsMobile)' == 'true' and '$(TargetsBrowser)' != 'true'">AppBundle</MobileAppBundleDirName>
-    <MobileAppBundleDirName Condition="'$(TargetsBrowser)' == 'true'">wwwroot</MobileAppBundleDirName>
+    <MobileAppBundleDirName Condition="'$(TargetsBrowserOnMono)' == 'true'">wwwroot</MobileAppBundleDirName>


RuntimeFlavor comparisons in this file use inconsistent casing (e.g. 'mono'/'coreclr' vs 'Mono'/'CoreCLR'). Since RuntimeFlavor is set by pipelines as 'CoreCLR' by default, conditions like TargetsBrowserOnCoreCLR and TargetsMobile will never become true, which can break the CoreCLR browser/wasm flow (NodeJS path, payload prep, log checker gating). Consider normalizing once (e.g. $(RuntimeFlavor.ToLowerInvariant())) or comparing against the actual cased values consistently throughout the file.

Copilot

Pull request overview

Copilot reviewed 58 out of 59 changed files in this pull request and generated 1 comment.

Copilot · 2026-02-12T22:10:48Z

src/tests/run.sh

+# Set default for RunWithNodeJS when using wasm architecture
+if [ "$buildArch" = "wasm" ] && [ -z "$RunWithNodeJS" ]; then
+    export RunWithNodeJS=1
+fi


RunWithNodeJS is now defaulted on whenever buildArch=wasm. However this happens before buildOS inference and also applies even if the caller explicitly sets buildOS=wasi, where the "--node" mode isn’t applicable. Consider moving this default after the wasm->browser defaulting, and gating it on buildOS=browser (or only when buildOS is unset), so WASI test runs don’t inadvertently get forced into NodeJS mode.

radekdoulik added 7 commits January 15, 2026 19:04

Alternative implementation

1016c3c

[wasm][coreclr] Build and run runtime tests on node

237de71

Based on changes from the previous branch (https://github.com/radekdoulik/runtime/tree/clr-wasm-runtime-tests-with-node)

Conditinally disable tests with threads on wasm in ST scenario

c7217c1

Add missing signuters for runtime tests

7e44832

Build artifacts and try to run tests

769df50

Reduce CI to browser_wasm temporarily

32e6a77

radekdoulik added this to the Future milestone Jan 20, 2026

radekdoulik added the area-Infrastructure-coreclr label Jan 20, 2026

github-project-automation bot added this to Runtime Infra Jan 20, 2026

dotnet-policy-service bot assigned radekdoulik Jan 20, 2026

Fix build_browser_wasm_linux_Release_CoreCLR_WasmBuildTests dependency

b5543f2

radekdoulik added 8 commits January 20, 2026 16:21

Fix build job suffix

7942bd0

Add hostedOs to the build dependency

37c67c9

Fix typo

7697993

Fix hostedOs location

3847f92

add jobParameters

d345451

Use hostedOs directly

d18ade8

Try to create the missing coreclr_common_test_build_p0_AnyOS_AnyCPU_c…

87d1662

…hecked job

Fix suffix

c4ad36d

build-analysis bot mentioned this pull request Jan 20, 2026

Assertion failures in System.Tests.ConvertTests.TryFromBase64Chars on Mono MiniJIT and Interpreter across multiple Linux and macOS platforms #123389

Closed

radekdoulik added 3 commits January 21, 2026 12:16

Use checked runtime configuration

840fea1

Fix build name for cases wiht hostedOs set

4febea9

Put back linux_x64 for CoreClrTestBuildHost

85c5607

jkoritzinsky reviewed Jan 21, 2026

View reviewed changes

radekdoulik added 3 commits January 22, 2026 13:00

Put TestAssemblies=false back

683842e

[wasm][coreclr] Implement portable RhExceptionHandling_FailedAllocati…

b4c8999

…on (dotnet#123215) Fixes dotnet#122923

Merge remote-tracking branch 'remotes/rodo/clr-interp-fix-helper-call…

edf3697

…s' into clr-wasm-runtime-tests-on-node-2

radekdoulik and others added 3 commits February 12, 2026 10:47

Revert "Skip native part of the test build on windows"

ebc56f3

This reverts commit af6321d.

Do not build native test assets on windows

821446d

Update src/tests/Common/CLRTest.Execute.Batch.targets

612a341

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 12, 2026 09:52

Copilot started reviewing on behalf of radekdoulik February 12, 2026 09:52 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

radekdoulik added 2 commits February 12, 2026 11:03

Split browser_wasm and browser_wasm_win to skip native assets build o…

2553b99

…n windows

Fix WBT artifacts name

5a6da68

Copilot AI review requested due to automatic review settings February 12, 2026 11:06

Copilot started reviewing on behalf of radekdoulik February 12, 2026 11:07 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

radekdoulik added 3 commits February 12, 2026 13:58

Fix build config for WBT

7c19f87

Fix timeout calc

97eb510

Escape $( for msbuild to not interpret it

afbdbc3

Copilot AI review requested due to automatic review settings February 12, 2026 13:21

Copilot started reviewing on behalf of radekdoulik February 12, 2026 13:22 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

Capitalize build config, Helix SDK seems case sensitive

eb776c0

build-analysis bot mentioned this pull request Feb 12, 2026

crossgen2 failing on Linux Arm32 intermittently #124007

Open

Add Release build for WBT

0535af7

Copilot AI review requested due to automatic review settings February 12, 2026 22:00

Copilot started reviewing on behalf of radekdoulik February 12, 2026 22:01 View session

Merge branch 'main' into clr-wasm-runtime-tests-on-node-2

2da88b2

Copilot AI reviewed Feb 12, 2026

View reviewed changes

Fix missing artifact for WBT

232bf3d

pavelsavara approved these changes Feb 13, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[wasm][coreclr] WIP runtime tests on CI#123377

[wasm][coreclr] WIP runtime tests on CI#123377
radekdoulik wants to merge 98 commits intodotnet:mainfrom
radekdoulik:clr-wasm-runtime-tests-on-node-2

radekdoulik commented Jan 20, 2026 •

edited

Loading

Uh oh!

radekdoulik commented Jan 20, 2026

Uh oh!

azure-pipelines bot commented Jan 20, 2026

Uh oh!

Uh oh!

jkoritzinsky Jan 21, 2026

Uh oh!

radekdoulik Jan 29, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

radekdoulik commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

radekdoulik commented Jan 20, 2026

Uh oh!

azure-pipelines bot commented Jan 20, 2026

Uh oh!

Uh oh!

jkoritzinsky Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

radekdoulik Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

radekdoulik commented Jan 20, 2026 •

edited

Loading