[wasm] Remove duplicated UseMonoRuntime=true from SDK#121789
Merged
maraf merged 2 commits intodotnet:mainfrom Dec 5, 2025
Merged
[wasm] Remove duplicated UseMonoRuntime=true from SDK#121789maraf merged 2 commits intodotnet:mainfrom
maraf merged 2 commits intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes UseMonoRuntime=true property assignments from two WebAssembly SDK build files, claiming they are duplicates of a property set in the external dotnet/sdk WasmSDK repository.
- Removes unconditional
UseMonoRuntime=truefromWasmApp.Common.props - Removes conditional
UseMonoRuntime=truefromMicrosoft.NET.Runtime.WebAssembly.Sdk/Sdk/Sdk.props
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/mono/wasm/build/WasmApp.Common.props | Removes unconditional UseMonoRuntime=true assignment that applies to all projects using the WebAssembly SDK |
| src/mono/nuget/Microsoft.NET.Runtime.WebAssembly.Sdk/Sdk/Sdk.props | Removes conditional UseMonoRuntime=true assignment that only applies when NOT using external Blazor/WebAssembly SDKs |
pavelsavara
approved these changes
Dec 5, 2025
maraf
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the removed assignments are duplicates. We have the property set in WasmSDK at https://github.com/dotnet/sdk/blob/main/src/WasmSdk/Sdk/Sdk.props#L18