JIT: Disallow insertions into SIMD registers for argument passing#119246
Merged
jakobbotsch merged 1 commit intodotnet:mainfrom Sep 2, 2025
Merged
JIT: Disallow insertions into SIMD registers for argument passing#119246jakobbotsch merged 1 commit intodotnet:mainfrom
jakobbotsch merged 1 commit intodotnet:mainfrom
Conversation
The backend would produce illegal IR for this case (like SIMD16 <- long bitcasts).
github-actions
bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the JIT's argument passing logic by preventing insertions into SIMD registers, which would cause the backend to generate illegal IR such as SIMD16 <- long bitcasts.
- Adds validation to disallow SIMD register insertions during field list compatibility checking
- Includes debug logging for better diagnostics when SIMD insertions are rejected
Member
Author
EgorBo
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backend would produce illegal IR for this case (like SIMD16 <- long bitcasts). Fixes a bug I saw in #118778.