Allow RUC to suppress generic warnings on type#118868
Closed
sbomer wants to merge 3 commits intodotnet:mainfrom
Closed
Allow RUC to suppress generic warnings on type#118868sbomer wants to merge 3 commits intodotnet:mainfrom
sbomer wants to merge 3 commits intodotnet:mainfrom
Conversation
github-actions
bot
added
the
area-Tools-ILLink
dotnet-policy-service
bot
added
the
linkable-framework
Contributor
|
Tagging subscribers to this area: @dotnet/illink |
This was referenced Aug 19, 2025
Contributor
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #108507
The fix was unfortunately complicated by the fact that we need to distinguish between warnings on the type due to:
All currently go through a shared helper to see whether a warning should be suppressed due to RUC, but with this change we only want it to be suppressed for 1).
Ideally my preference would be to uniformly treat
Requireson type as suppressing warnings from the type, including warnings for attributes applied to the type. But that would require a different warning model for attributes (#108501).