Fix bad deallocate for zero-length allocations in jit allocator#118866
Merged
kg merged 1 commit intodotnet:mainfrom Aug 19, 2025
Merged
Fix bad deallocate for zero-length allocations in jit allocator#118866kg merged 1 commit intodotnet:mainfrom
kg merged 1 commit intodotnet:mainfrom
Conversation
github-actions
bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the JIT allocator where zero-length allocations were causing incorrect deallocation behavior. The issue occurs when the allocator returns a reference to a static target for zero-length allocations, but then attempts to deallocate that reference as if it were a normal heap allocation.
- Adds a safety check to prevent deallocation of the zero-length allocation target
- Protects against potential crashes or undefined behavior during memory cleanup
jakobbotsch
approved these changes
Aug 18, 2025
Member
jakobbotsch
left a comment
jakobbotsch
left a comment
There was a problem hiding this comment.
CompAllocator::dellocate called below is a no-op, so no actual bug here. But the change seems good anyway to mirror what happens in alloc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is a bug.