Skip to content

Comments

Fix the issue of Mono.AotCross build errors#117971

Merged
akoeplinger merged 2 commits intodotnet:mainfrom
Linlccc:fix-aotcross-build
Aug 18, 2025
Merged

Fix the issue of Mono.AotCross build errors#117971
akoeplinger merged 2 commits intodotnet:mainfrom
Linlccc:fix-aotcross-build

Conversation

@Linlccc
Copy link
Contributor

@Linlccc Linlccc commented Jul 23, 2025

Configure the DotNetBuildMonoCrossAOT property when building Mono.AotCross

Fixes #117970

@Linlccc
Fix the issue of Mono.AotCross build errors
c9be6f4 
Configure the DotNetBuildMonoCrossAOT property when building Mono.AotCross

Fixes dotnet#117970
Copilot AI review requested due to automatic review settings July 23, 2025 08:06
Copilot AI reviewed Jul 23, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes build errors in the Mono.AotCross component by configuring the DotNetBuildMonoCrossAOT property when building the Mono cross-compilation AOT toolchain.

  • Adds the DotNetBuildMonoCrossAOT=true property to the Mono.AotCross build configuration
  • Resolves issue #117970 related to Mono cross-compilation AOT build failures

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 23, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 23, 2025
This was referenced Jul 23, 2025
Closed
Closed
@jkotas jkotas added area-Infrastructure-mono and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 23, 2025
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Jul 23, 2025

Tagging subscribers to this area: @akoeplinger, @matouskozak, @simonrozsival
See info in area-owners.md if you want to be subscribed.

@akoeplinger
Copy link
Member

akoeplinger commented Jul 23, 2025

if you just build mono.aotcross the expectation is that you set MonoCrossAOTTargetOS

@Linlccc
Copy link
Contributor Author

Linlccc commented Jul 23, 2025 •
edited
Loading

if you just build mono.aotcross the expectation is that you set MonoCrossAOTTargetOS

You are right. When using ./build.sh -s Mono.AotCross, if there is no TargetOS, you should prompt to set MonoCrossAOTTargetOS

@Linlccc
Fix the issue of Mono.AotCross build errors
05af316 
Remove the DotNetBuildMonoCrossAOT default value when building Mono.AotCross
Check MonoAotTarget before building and prompt

Fixes dotnet#117970
@akoeplinger
Copy link
Member

akoeplinger commented Jul 23, 2025 •
edited
Loading

so is running AllSubsets your main use case? this was added basically just for restoring: #117374

I'm not sure it makes much sense to support this for building too

@Linlccc
Copy link
Contributor Author

Linlccc commented Jul 23, 2025

@dotnet-policy-service agree

@Linlccc
Copy link
Contributor Author

Linlccc commented Jul 23, 2025

so is running AllSubsets your main use case? this was added basically just for restoring: #117374

I'm not sure it makes much sense to support this for building too

Yes, now it will only check the target and give a prompt before building

This was referenced Jul 23, 2025
Open
Open
Open
@Linlccc
Copy link
Contributor Author

Linlccc commented Jul 25, 2025

@steveisok Are there any issues with the current PR that are preventing it from being merged?

steveisok
steveisok approved these changes Aug 18, 2025
View reviewed changes
Copy link
Member

@steveisok steveisok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@steveisok
Copy link
Member

steveisok commented Aug 18, 2025

@akoeplinger are you ok w/ the change?

@akoeplinger
Copy link
Member

akoeplinger commented Aug 18, 2025

/ba-g unrelated test failures

@akoeplinger akoeplinger merged commit 9373c61 into dotnet:main Aug 18, 2025
64 of 70 checks passed
@akoeplinger
Copy link
Member

akoeplinger commented Aug 18, 2025

Thanks and sorry for the delay!

Linlccc added a commit to Linlccc/runtime that referenced this pull request Aug 18, 2025
@Linlccc
Revert "Fix the issue of Mono.AotCross build errors (dotnet#117971)"
dae70bd 
This reverts commit 9373c61.
@Linlccc Linlccc deleted the fix-aotcross-build branch August 18, 2025 15:08
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@steveisok steveisok steveisok approved these changes

@akoeplinger akoeplinger akoeplinger approved these changes

@vitek-karas vitek-karas Awaiting requested review from vitek-karas vitek-karas is a code owner

Assignees

No one assigned

Labels

area-Infrastructure-mono community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build Mono.AotCross error

4 participants

@Linlccc @akoeplinger @steveisok @jkotas