disable multicast tests on AzureLinux#117694
Merged
wfurt merged 8 commits intodotnet:mainfrom Jul 22, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR disables multicast tests on AzureLinux by introducing a new conditional check that excludes platforms where multicast functionality is not available or blocked. The change consolidates existing platform exclusions and adds AzureLinux to the list of platforms that cannot run multicast tests due to firewall restrictions.
Key Changes:
- Introduces a new
CanRunMulticastTestsproperty that consolidates platform checks for multicast test compatibility - Replaces individual
ConditionalFactandActiveIssueattributes with a single unified condition - Adds AzureLinux to the list of platforms excluded from multicast tests
Comments suppressed due to low confidence (1)
src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs:20
- [nitpick] The property name
CanRunMulticastTestsuses a positive naming convention but is implemented with negation logic. Consider renaming toShouldSkipMulticastTestsor restructuring the logic to avoid double negation for better readability.
private static readonly bool CanRunMulticastTests = !(PlatformDetection.IsNotWindowsNanoNorServerCore ||
Contributor
|
Tagging subscribers to this area: @dotnet/ncl |
This was referenced Jul 16, 2025
Open
This was referenced Jul 17, 2025
ManickaP
reviewed
Jul 21, 2025
src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs
Outdated
Show resolved
Hide resolved
Member
|
/ba-g failures unrelated |
Member
|
/backport to release/9.0-staging |
Contributor
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/17566620163 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #115502.
default AZL has firewall that blocks multicast.