Implement various SVE2 Multiply Instructions#117660
Implement various SVE2 Multiply Instructions#117660amanasifkhalid merged 3 commits intodotnet:mainfrom
Conversation
Includes: * MultiplyAddBySelectedScalar * MultiplyBySelectedScalar * MultiplyBySelectedScalarWideningEven * MultiplyBySelectedScalarWideningEvenAndAdd * MultiplyBySelectedScalarWideningEvenAndSubtract * MultiplyBySelectedScalarWideningOdd * MultiplyBySelectedScalarWideningOddAndAdd * MultiplyBySelectedScalarWideningOddAndSubtract * MultiplySubtractBySelectedScalar * MultiplyWideningEven * MultiplyWideningEvenAndAdd * MultiplyWideningEvenAndSubtract * MultiplyWideningOdd * MultiplyWideningOddAndAdd * MultiplyWideningOddAndSubtract * PolynomialMultiply * PolynomialMultiplyWideningEven * PolynomialMultiplyWideningOdd
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
amanasifkhalid
left a comment
amanasifkhalid
left a comment
There was a problem hiding this comment.
I think you're missing some APIs in the .cs files, for example MultiplyWideningEvenAndSubtract in Sve2.PlatformNotSupported.cs. Also, there are extra definitions of MultiplyBySelectedScalarWideningEvenAndSubtract in Sve2.cs that don't have the index arg -- did you mean to get rid of this?
Thank you, yes these names were copied incorrectly in that file. I've pushed a fix. |
amanasifkhalid
left a comment
amanasifkhalid
left a comment
There was a problem hiding this comment.
Code changes LGTM, just want to make sure emitter tests are still passing
|
Merging from main, now that we have SPMI collections |
|
fyi, the saturate functions from the math list are mostly completed, but are blocked behind this PR getting merged because there's some work from this PR they need. |
amanasifkhalid
left a comment
amanasifkhalid
left a comment
There was a problem hiding this comment.
fyi, the saturate functions from the math list are mostly completed, but are blocked behind this PR getting merged because there's some work from this PR they need.
I'm gonna go ahead and merge this to unblock that work. I'll run the emitter tests locally and PR a fix, if needed.
|
/ba-g nativeaot and android-x64 build timeouts |
Thanks. I think all it needs is to revert the changes in codegentest file from #116848 except for the block containing |
3 participants
Includes: