Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses test flakiness in the AssemblyNameInfo tests by simplifying the test cases and assertions on the culture name conversion.
- Removed platform‐dependent member data and conditional test attributes
- Replaced the expected lower-cased culture value with a computed value using CultureInfo to normalize output across frameworks
Comments suppressed due to low confidence (2)
src/libraries/System.Reflection.Metadata/tests/Metadata/AssemblyNameInfoTests.cs:108
- Ensure that the new inline test cases fully cover all scenarios previously addressed by the removed CultureNameGetLoweredByToAssemblyName_Arguments method. If there are additional edge cases to validate, consider adding them.
}
src/libraries/System.Reflection.Metadata/tests/Metadata/AssemblyNameInfoTests.cs:122
- Using CultureInfo(input).Name as the expected value makes the test more robust across platforms; please confirm that this behavior is consistent across all targeted frameworks.
Assert.Equal(new CultureInfo(input).Name, assemblyNameInfo.ToAssemblyName().CultureName);
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-reflection-metadata |
This was referenced Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #117172