Revert "Merging internal commits for release/8.0"

[hoyosjs]

No description provided.

[Copilot]

Pull Request Overview

This pull request reverts a set of internal commits that introduced stricter absolute path validations and additional test scenarios. Key changes include:

• Removal of absolute path checks in coreclr, fxr, and hostpolicy resolvers.
• Reversion of changes to the condition for adding known probe directories in deps_resolver.
• Removal of several tests related to "IgnoreWorkingDirectory" functionality.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/native/corehost/hostpolicy/standalone/coreclr_resolver.cpp	Removed absolute path validation for coreclr DLL loading.
src/native/corehost/deps_resolver.cpp	Changed condition for adding probe directory locations.
src/native/corehost/fxr_resolver.h	Removed absolute path check for fxr path.
src/native/corehost/fxr/standalone/hostpolicy_resolver.cpp	Removed absolute path check for hostpolicy path.
src/native/corehost/apphost/standalone/hostfxr_resolver.cpp	Removed absolute path check for hostfxr path.
src/installer/tests/TestUtils/TestArtifact.cs	Removed factory method for test artifacts.
src/installer/tests/HostActivation.Tests/NativeHosting/LoadAssemblyAndGetFunctionPointer.cs	Removed test validating working directory ignorance.
src/installer/tests/HostActivation.Tests/NativeHosting/Ijwhost.cs	Removed test validating working directory ignorance.
src/installer/tests/HostActivation.Tests/NativeHosting/FunctionPointerResultExtensions.cs	Renamed test helper class and removed resolution methods.
src/installer/tests/HostActivation.Tests/NativeHosting/Comhost.cs	Removed test validating working directory ignorance.

Comments suppressed due to low confidence (9)

src/native/corehost/hostpolicy/standalone/coreclr_resolver.cpp:15

• Removal of the absolute path check for coreclr may allow non-absolute paths to be used. Please confirm that this change is intentional and that upstream logic guarantees an absolute path.

// We should always be loading coreclr from an absolute path

src/native/corehost/deps_resolver.cpp:832

• The condition change removes the libhost check before adding known locations, which might run add_unique_path with an empty m_app_dir in libhost scenarios. Verify this behavior is expected.

if (!get_app_deps().exists())

src/native/corehost/fxr_resolver.h:46

• The removed absolute path check for fxr_path may affect library resolution if relative paths are provided. Please ensure that the change aligns with overall hostfxr loading requirements.

if (!pal::is_path_rooted(fxr_path))

src/native/corehost/fxr/standalone/hostpolicy_resolver.cpp:180

• Removing the absolute path check for hostpolicy's host_path requires confirmation that host_path is reliably absolute elsewhere. Verify that this change does not introduce path resolution issues.

if (!pal::is_path_rooted(host_path))

src/native/corehost/apphost/standalone/hostfxr_resolver.cpp:38

• The removal of the absolute path check for m_fxr_path may allow invalid paths to be processed. Confirm that m_fxr_path is always provided as an absolute path or that the new behavior is acceptable.

else if (!pal::is_path_rooted(m_fxr_path))

src/installer/tests/HostActivation.Tests/NativeHosting/LoadAssemblyAndGetFunctionPointer.cs:234

• The test 'CallDelegateOnComponentContext_IgnoreWorkingDirectory' has been removed. Please verify that this removal does not leave a gap in test coverage for scenarios where the working directory should be ignored.

[Fact]

src/installer/tests/HostActivation.Tests/NativeHosting/Ijwhost.cs:73

• The test 'LoadLibrary_IgnoreWorkingDirectory' has been removed. Confirm that this removal is intentional and that any required coverage for working directory handling is maintained.

[Fact]

src/installer/tests/HostActivation.Tests/NativeHosting/FunctionPointerResultExtensions.cs:8

• The renaming of the helper class from 'NativeHostingResultExtensions' to 'FunctionPointerResultExtensions' should be verified to ensure that all dependent tests and references have been updated accordingly.

internal static class FunctionPointerResultExtensions

src/installer/tests/HostActivation.Tests/NativeHosting/Comhost.cs:116

• The removal of the test 'ActivateClass_IgnoreWorkingDirectory' may reduce coverage for handling working directories. Please ensure that the relevant scenarios are still adequately tested elsewhere.

[Fact]

[hoyosjs]

Merge quickly to fixup mirroring.