Partial revert of "Delete LOADEDMODULES cache", additional cleanup#116374
Merged
jkotas merged 3 commits intodotnet:mainfrom Jun 7, 2025
Merged
Partial revert of "Delete LOADEDMODULES cache", additional cleanup#116374jkotas merged 3 commits intodotnet:mainfrom
jkotas merged 3 commits intodotnet:mainfrom
Conversation
github-actions
bot
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR partially reverts the deletion of the LOADEDMODULES cache and reintroduces the implementation of IMetaDataImport::ResolveTypeRef to avoid breaking profiler tests. Key changes include:
- Re-adding caching support via RegMeta::AddToCache and restoring ResolveTypeRef in regmeta_vm.cpp.
- Removing obsolete COM class factory code and related functions.
- Updating build scripts to include the new VM caching definitions and remove deprecated sources.
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/md/enc/mdinternalrw.cpp | Added call to AddToCache to update cache after interface setup. |
| src/coreclr/md/compiler/regmeta_vm.cpp | Restored AddToCache and ResolveTypeRef implementations. |
| src/coreclr/md/compiler/regmeta.cpp | Removed old Release implementation and updated QueryInterface. |
| src/coreclr/md/compiler/disp.cpp | Added calls to AddToCache in various scope creation routines. |
| Various CMakeLists.txt and header files | Removed obsolete class factory code and added FEATURE_METADATA_IN_VM definition. |
Comments suppressed due to low confidence (1)
src/coreclr/md/CMakeLists.txt:4
- Ensure that the addition of FEATURE_METADATA_IN_VM is compatible with all dependent modules and that its behavior is clearly documented in related developer guides.
add_compile_definitions($<$<NOT:$<OR:$<BOOL:$<TARGET_PROPERTY:DAC_COMPONENT>>,$<BOOL:$<TARGET_PROPERTY:DBI_COMPONENT>>>>:FEATURE_METADATA_IN_VM>)
jkotas
added
area-VM-coreclr
and removed
needs-area-label
Contributor
|
Tagging subscribers to this area: @mangod9 |
tommcdon
approved these changes
Jun 6, 2025
Member
tommcdon
left a comment
tommcdon
left a comment
There was a problem hiding this comment.
Thank you! The changes look good!
Member
Author
|
/ba-g timeout |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding back implementation of IMetaDataImport::ResolveTypeRef to avoid breaking profilers. The break was detected by internal profiler tests.
Also deleted unnecessary IClassFactory implementation.