Remove CreateFalse node during lowering, if MaskToVector is getting removed#114272
Merged
kunalspathak merged 5 commits intodotnet:mainfrom Apr 7, 2025
Merged
Remove CreateFalse node during lowering, if MaskToVector is getting removed#114272kunalspathak merged 5 commits intodotnet:mainfrom
kunalspathak merged 5 commits intodotnet:mainfrom
Conversation
ghost
added
the
area-CodeGen-coreclr
Contributor
Author
|
@dotnet/jit-contrib @dotnet/arm64-contrib |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
Author
Contributor
Author
|
/azp run Fuzzlyn, Antigen |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jakobbotsch
reviewed
Apr 6, 2025
jakobbotsch
approved these changes
Apr 7, 2025
Contributor
Author
|
/azp run Fuzzlyn |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
osx/arm64 fuzzlyn failure is #113940 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During lowering, if we see
CndSel(AllTrue, op2, op3), we replace it withop2and deleteAllTrueandop3. Ifop3isAllFalse, we remove it too. However, it can be wrapped inMaskToVector(AllFalse)and in such case, we would just deleteMaskToVectornode and notAllFalsenode. Fixed by removing that node as well.Fixes: #113338