Don't expose TrustedCertificatesDirectory() and StartNewTlsSessionContext() to NetFx#113963
Don't expose TrustedCertificatesDirectory() and StartNewTlsSessionContext() to NetFx#113963steveharter merged 1 commit intodotnet:mainfrom
Conversation
|
Note regarding the |
1 similar comment
|
Note regarding the |
There was a problem hiding this comment.
Pull Request Overview
This PR prevents exposing the TrustedCertificatesDirectory property and StartNewTlsSessionContext method to NetFx by conditionally compiling them for NET targets only.
- Guard TrustedCertificatesDirectory with #if NET and mark it with the UnsupportedOSPlatformAttribute.
- Guard StartNewTlsSessionContext with #if NET and mark it accordingly.
|
Tagging subscribers to this area: @dotnet/area-system-directoryservices, @jay98014 |
|
That's a breaking change, isn't it? |
No. The method was just introduced and is not implemented on .NET Framework. |
ericstj
left a comment
There was a problem hiding this comment.
Change looks OK.
It would be nice if we could make API Compat add an additional compatibility tuple for these cases where we don't build for NETFX but expect to be compatible with an assembly in the targeting pack @ViktorHofer
|
If you refer to following placeholder files in a comparison tuple, yes we should support that. This is tracked under dotnet/sdk#18165 and dotnet/sdk#27822 attempted to fix that. Never found time to finish it. |
|
/backport to release/9.0-staging |
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/14644505815 |
|
/backport to release/8.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/14648563757 |
Fixes #113947
Will need to backport to v9 and v8.