[DAC] ClrDataAccess::GetFrameName support Frames using identifier instead of vptr#112488
Merged
jkotas merged 3 commits intodotnet:mainfrom Feb 13, 2025
Merged
[DAC] ClrDataAccess::GetFrameName support Frames using identifier instead of vptr#112488jkotas merged 3 commits intodotnet:mainfrom
jkotas merged 3 commits intodotnet:mainfrom
Conversation
ghost
added
the
Contributor
|
Tagging subscribers to this area: @tommcdon |
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (3)
- src/coreclr/debug/daccess/dacfn.cpp: Language not supported
- src/coreclr/debug/daccess/request.cpp: Language not supported
- src/coreclr/inc/daccess.h: Language not supported
jkotas
reviewed
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#112166 converted Frames to use a
FrameIdentifiervalue instead of a VPtr to differentiate types, removing all Frame types from the list ofVPTR_CLASS's.ClrDataAccess::GetFrameNamepreviously searched for the Frame name from the list ofVPTR_CLASS's, this PR converts the logic to use theFrameIdentifiervalue instead.Note, there is
Frame::GetFrameTypeNamewhich could be reused but would require refactoring as it is only compiled inDEBUG, non-DAC builds.