[browser] single threaded diagnostic server#111910
Merged
pavelsavara merged 22 commits intodotnet:mainfrom Feb 20, 2025
Merged
Conversation
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing |
Member
Author
|
@lateralusX please review this first step |
This was referenced Jan 29, 2025
Open
maraf
reviewed
Jan 29, 2025
This was referenced Feb 5, 2025
38 tasks
# Conflicts: # src/native/eventpipe/CMakeLists.txt
lateralusX
reviewed
Feb 10, 2025
Member
lateralusX
left a comment
There was a problem hiding this comment.
Second pass on the EP code, mainly code structural comments as well as one idea around ep_rt_thread_create.
This was referenced Feb 10, 2025
lateralusX
approved these changes
Feb 13, 2025
Member
lateralusX
left a comment
There was a problem hiding this comment.
Native Mono and EventPipe changes LGTM! Thanks!
This was referenced Feb 13, 2025
Member
Author
|
To be merged after preview snap |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is split from #110818 to make code review easier
Enabled by
<WasmPerfTracing>true</WasmPerfTracing>and also<MetricsSupport>and<EventSourceSupport>as necessary.Single thread
ep_rt_thread_createandep_rt_thread_mono_start_funcstreaming_loop_tickrefactored fromstreaming_threadserver_loop_tickfrom refactoredserver_threadmono_wasm_ds_execto process on tick on event loopmono_schedule_ds_jobwill register callback into queue for aboveep_rt_wait_event_waitFEATURE_PERFTRACING_DISABLE_THREADS->PERFTRACING_DISABLE_THREADSds_ipc_stream_factory_get_next_available_streamonly polls once and never blocksSampling
sampling_threadbecause we can't do "stop-the-world and scan other threads"ep_rt_sample_profiler_enabledandep_rt_sample_profiler_disabledep_rt_mono_sampling_provider_component_initMONO_PROFILER_CALL_INSTRUMENTATION_ENTERFeaturePerfTracingFeaturePerfTracingSamplingto enable/disable this if necessaryWeb socket
FEATURE_PERFTRACING_PAL_WSds-ipc-pal-websocket.candds-ipc-pal-websocket.hthey just forward to JavaScriptds_rt_websocket_create,ds_rt_websocket_send,ds_rt_websocket_poll,ds_rt_websocket_recv,ds_rt_websocket_closeOther
diagnostics_tracing-static.ain in-tree buildsMicrosoft.NETCore.App.Runtime.Mono.perftrace.**RID**cleanupSystemNative_GetCpuUtilizationNext PRs
MINT_SDB_SEQ_POINTor similarOut of scope
contributes to #76316