Skip to content

Support building the repo with clang 20#109756

Merged
jkoritzinsky merged 3 commits intodotnet:mainfrom
jkoritzinsky:clang-20
Nov 13, 2024
Merged

Support building the repo with clang 20#109756
jkoritzinsky merged 3 commits intodotnet:mainfrom
jkoritzinsky:clang-20

Conversation

@jkoritzinsky
Copy link
Member

@jkoritzinsky jkoritzinsky commented Nov 12, 2024

Fix errors from building with clang-20.

The issues were:

  • Using memcpy with non-trivial structs became warn-as-error.
  • our "safe to return" pattern breaks in constexpr in C++11 mode and clang-20 updated their intrinsics headers to make intrinsics constexpr. Include the intrinsics headers before we ever include debugreturn.h

am11
am11 reviewed Nov 12, 2024
View reviewed changes
jkotas
jkotas reviewed Nov 12, 2024
View reviewed changes
This was referenced Nov 13, 2024
Open
Closed
@jkoritzinsky
Copy link
Member Author

jkoritzinsky commented Nov 13, 2024

/ba-g timeouts unrelated

@jkoritzinsky jkoritzinsky merged commit 80367bf into dotnet:main Nov 13, 2024
@jkoritzinsky jkoritzinsky deleted the clang-20 branch November 13, 2024 03:26
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
@jkoritzinsky @mikelle-rogers
Support building the repo with clang 20 (dotnet#109756)
bed7b93
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotas jkotas jkotas approved these changes

@hoyosjs hoyosjs Awaiting requested review from hoyosjs

+1 more reviewer

@am11 am11 am11 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jkoritzinsky jkoritzinsky

Labels

area-Infrastructure-coreclr

Projects

Runtime Infra
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jkoritzinsky @am11 @jkotas