Remove MethodDesc::GetSig#109211
Merged
AaronRobinsonMSFT merged 1 commit intodotnet:mainfrom Oct 25, 2024
Merged
Conversation
This API is inherently unsafe because it doesn't provide a length. All uses are replaced with MethodDesc::GetSigPointer or MethodDesc::GetSigParser.
AaronRobinsonMSFT
requested review from
davidwrighton,
elinor-fung and
jkotas
AaronRobinsonMSFT
changed the title
MethodDesc::GetSig.MethodDesc::GetSig
Contributor
|
Tagging subscribers to this area: @mangod9 |
jkotas
approved these changes
Oct 25, 2024
am11
reviewed
Oct 25, 2024
|
|
||
| BYTE callConv = sig.GetCallingConventionInfo(); | ||
| if (callConv != (IMAGE_CEE_CS_CALLCONV_HASTHIS | IMAGE_CEE_CS_CALLCONV_DEFAULT)) | ||
| COMPlusThrow(kInvalidProgramException); |
Member
There was a problem hiding this comment.
Just curious, does this use HMF or is it already on the asm helper plan under the hood?
Member
Author
There was a problem hiding this comment.
It doesn't use HMF since this must be called when an actual transition is performed - a QCall. The QCall erects a normal transition frame to unmanaged. Note that SuppressGCTransition on a QCall makes this call invalid. The COMPlusThrow APIs hook into the normal .NET exception mechanism here. I'm not the expert in this domain so if you need more details @jkotas or @janvorli are best to comment on how it aligns with the referenced approach/comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This API is inherently unsafe because it doesn't provide a length. All uses are replaced with
MethodDesc::GetSigPointerorMethodDesc::GetSigParser. Both of which ensure bounds are respected during any parsing.