Skip to content

Do not ignore MemoryMarshal.TryWrite result #108661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannergooding merged 1 commit into from
Jan 10, 2025
Merged

Do not ignore MemoryMarshal.TryWrite result #108661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/libraries/System.Private.CoreLib/src/System/Guid.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -914,13 +914,13 @@ public byte[] ToByteArray()
var g = new byte[16];
if (BitConverter.IsLittleEndian)
{
MemoryMarshal.TryWrite(g, in this);
MemoryMarshal.Write(g, in this);
}
else
{
// slower path for BigEndian
Guid guid = new Guid(MemoryMarshal.AsBytes(new ReadOnlySpan<Guid>(in this)), false);
MemoryMarshal.TryWrite(g, in guid);
MemoryMarshal.Write(g, in guid);
}
return g;
}
Expand All @@ -932,13 +932,13 @@ public byte[] ToByteArray(bool bigEndian)
var g = new byte[16];
if (BitConverter.IsLittleEndian != bigEndian)
{
MemoryMarshal.TryWrite(g, in this);
MemoryMarshal.Write(g, in this);
}
else
{
// slower path for Reverse
Guid guid = new Guid(MemoryMarshal.AsBytes(new ReadOnlySpan<Guid>(in this)), bigEndian);
MemoryMarshal.TryWrite(g, in guid);
MemoryMarshal.Write(g, in guid);
}
return g;
}
Expand All @@ -951,13 +951,13 @@ public bool TryWriteBytes(Span<byte> destination)

if (BitConverter.IsLittleEndian)
{
MemoryMarshal.TryWrite(destination, in this);
MemoryMarshal.Write(destination, in this);
}
else
{
// slower path for BigEndian
Guid guid = new Guid(MemoryMarshal.AsBytes(new ReadOnlySpan<Guid>(in this)), false);
MemoryMarshal.TryWrite(destination, in guid);
MemoryMarshal.Write(destination, in guid);
}
return true;
}
Expand All @@ -973,13 +973,13 @@ public bool TryWriteBytes(Span<byte> destination, bool bigEndian, out int bytesW

if (BitConverter.IsLittleEndian != bigEndian)
{
MemoryMarshal.TryWrite(destination, in this);
MemoryMarshal.Write(destination, in this);
}
else
{
// slower path for Reverse
Guid guid = new Guid(MemoryMarshal.AsBytes(new ReadOnlySpan<Guid>(in this)), bigEndian);
MemoryMarshal.TryWrite(destination, in guid);
MemoryMarshal.Write(destination, in guid);
}
bytesWritten = 16;
return true;
Expand Down