RandomAccess.Write throws System.IO.IOException when buffers total size greater than 2GB#108380
Merged
adamsitnik merged 2 commits intodotnet:mainfrom Oct 2, 2024
Conversation
adamsitnik
approved these changes
Oct 2, 2024
Member
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, thank you for your contribution @NicoAvanzDev !
Member
|
/ba-g crypto failure is unrelated |
Member
|
@jeffhandley @stephentoub once I get back from the vacations I am going to add test for it and backport it to supported versions |
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Oct 3, 2024
lambdageek
pushed a commit
to lambdageek/runtime
that referenced
this pull request
Oct 3, 2024
This was referenced Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #108322
Description
Fixes RandomAccess.Write that throws System.IO.IOException on windows machine where the buffer is larger than 2GB
Customer Impact
Possible file corruption when writing
Regression
#108322 (comment)
Testing
Without the fix:

With the fix:

Test method
The actual UnmanagedFileLoader implementation can be found here from official microsoft documentation
Risk
None
Package authoring signed off?
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.