Arm: Free up upper-half register that was not ready because of its association with busy lower-half register#107714
Merged
kunalspathak merged 12 commits intodotnet:mainfrom Sep 14, 2024
Merged
Conversation
ghost
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
kunalspathak
changed the title
3 tasks
Contributor
Author
|
@dotnet/jit-contrib @AndyAyersMS |
AndyAyersMS
approved these changes
Sep 13, 2024
Member
AndyAyersMS
left a comment
AndyAyersMS
left a comment
There was a problem hiding this comment.
Maybe you could run fuzzlyn on this PR?
Contributor
Author
yes, thanks for reminding. Wanted to run after CI is green, but forgot. |
Contributor
Author
|
/azp run Fuzzlyn |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run Antigen |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
No Fuzzlyn failures on linux/arm |
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
…sociation with busy lower-half register (dotnet#107714) * make sure the upperHalf is moved to ready pool when lowerHalf holding DOUBLE interval is done * remove the logging * added test cases * fix a typo * Add missing Xunit reference * Revert "remove the logging" This reverts commit d8f2f17. * better fix to free up upperHalf if lowerHalf is getting freed up * jit format * Revert "remove the logging" This reverts commit d8f2f17. * Handle upperHalf fix similar to lowerHalf code * formatting * jit format
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
…sociation with busy lower-half register (dotnet#107714) * make sure the upperHalf is moved to ready pool when lowerHalf holding DOUBLE interval is done * remove the logging * added test cases * fix a typo * Add missing Xunit reference * Revert "remove the logging" This reverts commit d8f2f17. * better fix to free up upperHalf if lowerHalf is getting freed up * jit format * Revert "remove the logging" This reverts commit d8f2f17. * Handle upperHalf fix similar to lowerHalf code * formatting * jit format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #107493, we were not releasing the upper half register from getting resolved, which was held back due to the fact that the lower half was occupied by a
TYP_DOUBLEinterval. However, when we free up the lower half, we should also mark the upper-half target as ready for resolution.Fixes: ##107621