[release/8.0-staging] Do not allow a non-keyed service to be injected to a keyed parameter#106877
Merged
ericstj merged 4 commits intorelease/8.0-stagingfrom Sep 4, 2024
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection |
…on.AllowNonKeyedServiceInject
Member
|
Need to enable this package for shipping. |
artl93
approved these changes
Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #105839 to release/8.0-staging plus a new feature switch for any compat issues.
See issue #102204.
/cc @steveharter
Customer Impact
A customer found unexpected behavior where a keyed service is injected when instead an exception should be thrown.
Regression
Testing
The tests from version 9 were ported here; also a compat feature switch was added called "Microsoft.Extensions.DependencyInjection.AllowNonKeyedServiceInject" that when set to
truewill allow the old behavior in case a customer depends on it. That feature switch does not exist in v9.0.Risk
Low. This is considered a breaking change since we now throw an exception; normally we don't add breaking changes in a service fix. However, consider: