Revert "Use ArgumentNullException.ThrowIfNull in more places (#105380)"#106108
Merged
stephentoub merged 1 commit intodotnet:mainfrom Aug 8, 2024
Merged
Revert "Use ArgumentNullException.ThrowIfNull in more places (#105380)"#106108stephentoub merged 1 commit intodotnet:mainfrom
stephentoub merged 1 commit intodotnet:mainfrom
Conversation
…105380)" Specifically the changes to System.Collections.Concurrent (ConcurrentDictionary)
ghost
added
the
This was referenced Aug 8, 2024
|
How come this affects performance to such an extent? |
eiriktsarpalis
approved these changes
Aug 8, 2024
Member
eiriktsarpalis
left a comment
eiriktsarpalis
left a comment
There was a problem hiding this comment.
Do we know why this is contributing to a perf regression?
Contributor
|
Is this the root cause? As #106027 (comment) says, it can't explain the regression on |
Member
Author
No. But we're too late too risk it. If this fixes the regression we can figure out why, and if it doesn't, we'll re-evaluate that issue but we won't have lost anything meaningful for 9 by reverting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically the changes to System.Collections.Concurrent (ConcurrentDictionary)
Fixes #106027
Fixes dotnet/perf-autofiling-issues#39525