Remove managed interfaces impls defined in CoreCLR#105965
Merged
AaronRobinsonMSFT merged 13 commits intodotnet:mainfrom Aug 17, 2024
Merged
Remove managed interfaces impls defined in CoreCLR#105965AaronRobinsonMSFT merged 13 commits intodotnet:mainfrom
AaronRobinsonMSFT merged 13 commits intodotnet:mainfrom
Conversation
ghost
added
the
Contributor
|
Tagging subscribers to this area: @mangod9 |
This was referenced Aug 5, 2024
Open
This was referenced Aug 12, 2024
This was referenced Aug 13, 2024
Member
Author
|
/cc @dotnet/interop-contrib |
elinor-fung
reviewed
Aug 16, 2024
This was referenced Aug 19, 2024
AaronRobinsonMSFT
added a commit
to AaronRobinsonMSFT/runtime
that referenced
this pull request
Aug 20, 2024
It appears that after dotnet#105965, the compiler is no longer inlining `TypeHandle::IsArray` for this code path. This deconstructs that use and reclaims it.
AaronRobinsonMSFT
added
breaking-change
Member
Author
|
Breaking change issue filed at dotnet/docs#49921 |
AaronRobinsonMSFT
removed
the
needs-breaking-change-doc-created
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
IReflectimplementation can be removed since we missed a supporting type after we brought this back in dotnet/coreclr#21343. The supporting type isSystem.Runtime.InteropServices.ComTypes.IReflect, which is needed for it to work at all. Thus, this scenario has never worked in .NET Core.Implement
IDynamicInterfaceCastableon__ComObjectto avoid managed interface definitions in unmanaged code -IEnumerableandIEnumerator. In an effort to ensure existing users are supported,ICustomAdapteris available when either of the previous two are supported. This allows us to remove the FCall forwarders that simulated a type of DIM for RCWs that implemented a conformingIDispatchorIEnumVARIANT.Verified that
EnumerableToDispatchMarshaleris not emitted by TlbImp.