Fix some core typeof(...) references#105903
Merged
steveharter merged 3 commits intodotnet:mainfrom Aug 8, 2024
Merged
Conversation
jkotas
reviewed
Aug 3, 2024
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/TypeBuilderImpl.cs
Outdated
Show resolved
Hide resolved
…t/TypeBuilderImpl.cs
This was referenced Aug 4, 2024
steveharter
approved these changes
Aug 7, 2024
This was referenced Aug 7, 2024
Contributor
|
Buyaa out, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typeof(ValueType)usage inDefineUninitializedDataonTypeBuildermentioned in DefineUninitializedData on TypeBuilder in System.Reflection.Emit uses typeof(ValueType) internally even when using a MetadataLoadContext #105772GetArrayMethodonModuleBuidlerthat usestypeof(void)EnumBuilderImplconstructor wheretypeof(Enum)is used as parent type, but according to the tests I added it appears to be fine, no need to changetypeof(Enum)reference hereruntime/src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/EnumBuilderImpl.cs
Lines 14 to 20 in f120fff
Fixes #105772