[browser] http streaming request server error#105709
Merged
lewing merged 2 commits intodotnet:mainfrom Aug 6, 2024
Merged
Conversation
Member
Author
|
cc @campersau , review welcome it seems that https://bugs.chromium.org/p/chromium/issues/detail?id=1480250 was fixed I guess it does no harm (with this PR) and we could delete it in Net10 |
This was referenced Jul 30, 2024
campersau
reviewed
Jul 30, 2024
Contributor
campersau
left a comment
There was a problem hiding this comment.
Yes, if the tests are passing without the fetch race workaround we could remove this logic.
src/libraries/System.Net.Http/src/System/Net/Http/BrowserHttpHandler/BrowserHttpHandler.cs
Show resolved
Hide resolved
This was referenced Jul 30, 2024
Closed
72f0183 to
6e1d285
Compare
This was referenced Aug 6, 2024
lewing
approved these changes
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http_wasm_transform_stream_writeandhttp_wasm_transform_stream_closeasBrowserHttpWriteStream.RejectedStatusCode.ashxtest helper to be able to delayAbortRequestandAbortResponseintoBrowserHttpInterop.AbortResponsehttp_wasm_abort_requestandhttp_wasm_abort_responseintohttp_wasm_aborthandle_abort_errorcontroller.abortControllerwhen there is nostreamWriterorstreamReaderBrowserHttpHandler_StreamingRequest_CancelRequeston CIFixes #104612