Skip to content

Rename cdac_offsets to cdac_data#105657

Merged
elinor-fung merged 2 commits intodotnet:mainfrom
elinor-fung:rename-cdac-offsets
Jul 30, 2024
Merged

Rename cdac_offsets to cdac_data#105657
elinor-fung merged 2 commits intodotnet:mainfrom
elinor-fung:rename-cdac-offsets

Conversation

@elinor-fung
Copy link
Member

The struct is used for exposing more than just offsets to the cDAC. Follow-up for #105534 (comment)

cc @jkoritzinsky

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit. Otherwise LGTM

Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
@elinor-fung elinor-fung merged commit 18eba09 into dotnet:main Jul 30, 2024
@elinor-fung elinor-fung deleted the rename-cdac-offsets branch July 30, 2024 02:34
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants