Add alternate system color experimental feature#105525
Merged
JeremyKuhne merged 2 commits intodotnet:mainfrom Jul 29, 2024
Merged
Add alternate system color experimental feature#105525JeremyKuhne merged 2 commits intodotnet:mainfrom
JeremyKuhne merged 2 commits intodotnet:mainfrom
Conversation
|
Note regarding the |
ghost
added
|
Note regarding the |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-drawing |
Member
Author
|
High contrast check is lifted from WinForms. |
ericstj
reviewed
Jul 29, 2024
src/libraries/System.Drawing.Primitives/src/System/Drawing/KnownColorTable.cs
Show resolved
Hide resolved
src/libraries/System.Drawing.Primitives/src/System/Drawing/KnownColorTable.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Drawing.Primitives/src/System/Drawing/KnownColorTable.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Drawing.Primitives/src/System/Drawing/SystemColors.cs
Show resolved
Hide resolved
Allows overriding KnownColor system values with an alternate set, which in the initial iteration is "dark mode" colors. Enables "dark mode" features in Windows Forms. This is from the approved part of dotnet/winforms#7641 with further naming iteration done offline with API review.
JeremyKuhne
force-pushed
the
alternatesyscolor
branch
from
1e46757 to
1011768
Compare
ericstj
reviewed
Jul 29, 2024
src/libraries/System.Drawing.Primitives/src/System/Drawing/KnownColorTable.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows overriding KnownColor system values with an alternate set, which in the initial iteration is "dark mode" colors. Enables "dark mode" features in Windows Forms.
This is from the approved part of dotnet/winforms#7641 with further naming iteration done offline with API review.
@KlausLoeffelmann pulled together the color set.
fyi: @ericstj