[release/9.0-preview7] Don't enable validation when UseDefaultServiceProvider is called#105356
Merged
carlossanlop merged 2 commits intorelease/9.0-preview7from Jul 24, 2024
Conversation
…tBuilderTests.cs Co-authored-by: Steve Harter <steveharter@users.noreply.github.com>
ghost
added
the
Contributor
|
Tagging subscribers to this area: @dotnet/area-extensions-hosting |
This was referenced Jul 24, 2024
Member
|
/ba-g all failures are known but it's not flipping to green because this is a release branch cc @carlossanlop @JulieLeeMSFT |
Contributor
|
The branch is also protected. PRs can only get merged via JIT elevation. |
carlossanlop
added
Servicing-approved
carlossanlop
approved these changes
Jul 24, 2024
Contributor
carlossanlop
left a comment
carlossanlop
left a comment
There was a problem hiding this comment.
Approved by Tactics via email.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #105170 to release/9.0-preview7
/cc @ericstj
Customer Impact
UseDefaultServiceProvider Is ignored. #99199 intentionally established new defaults for
ServiceProviderOptionsin development environment. However it did not honor changes made toServiceProviderOptionswithUseDefaultServiceProvider. This can cause applications to fail calls toHostBuilder.Build()as they will now be doing new validation.This regression was found in App Compat testing.
Regression
#99199
Testing
App testing to verify fix. Unit tests added.
Risk
Low. This change makes a previous change less breaking. The original change is still breaking but this helps us better understand if that's too breaking and needs to be reverted completely or not.