Conversation
am11
requested review from
MichalStrehovsky,
lambdageek,
marek-safar,
steveisok and
thaystg
as code owners
ghost
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
There was a problem hiding this comment.
@jakobbotsch, I deleted these scripts because they seem outdated since the repo unification. Please let me know if they should stay.
There was a problem hiding this comment.
I think that's fine... I don't think anyone uses or would use this anymore. cc @dotnet/jit-contrib
am11
added
area-Meta
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/area-meta |
src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/CompilerServices/Unsafe.cs
Outdated
Show resolved
Hide resolved
| @@ -1,1325 +0,0 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
These scripts seem outdated and unused by anything in the repo.
…Services/Unsafe.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>
| using System.Collections.Generic; | ||
| using System.Threading.Tasks; | ||
|
|
||
| namespace CoreFXTestLibrary |
There was a problem hiding this comment.
CoreFXTestLibrary was one of the old internal .NET test frameworks used before OSS. The native aot dynamic generics tests are the only place where it is still used. We have migrated away from it everywhere else.
I think RuntimeLibrariesTest is too noble name for it. I would leave it alone. Ideally, all this would be deleted and replaced with xunit (our xunit fork that is not reflection heavy that we use in other places).
If you really want to get rid of the CoreFX name, I would rename it to something that better describes what it is, e.g. LegacyTestLibrary.
| /// Creates compiler runner instances for each supported compiler based on the populated BuildOptions. | ||
| /// </summary> | ||
| /// <param name="isFramework">True if compiling the CoreFX framework assemblies</param> | ||
| /// <param name="isFramework">True if compiling the runtime libraries assemblies</param> |
There was a problem hiding this comment.
We've typically used "core libraries" (analogous to corelib which is just one). I've not heard "runtime libraries ". I edited the glossary too Core libraries
There was a problem hiding this comment.
I've not heard "runtime libraries "
- https://github.com/search?q=repo%3Adotnet%2Fruntime%20%22runtime%20libraries%22&type=code
- https://learn.microsoft.com/en-us/dotnet/standard/runtime-libraries-overview
CoreLib specifically implies System.Private.CoreLib.
5 participants
Continues on #105275