Add support for Add Sve.GatherVectorUInt*ZeroExtendFirstFaulting() by SwapnilGaikwad · Pull Request #105030 · dotnet/runtime

SwapnilGaikwad · 2024-07-17T15:04:36Z

Contribute towards #99957

@a74nh @kunalspathak @dotnet/arm64-contrib @arch-arm64-sve

…ectorFirstFaulting.

…ly without the FirstFaulting test. Added SveFfrTest template.

ghost · 2024-07-17T15:04:49Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2024-07-17T15:04:51Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-07-17T15:05:31Z

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

SwapnilGaikwad · 2024-08-08T22:31:48Z

@TIHan @amanasifkhalid @a74nh
As both #105595 and #104964 merged, I have rebased this PR and it's now ready for review.

Stress tests for the new GatherVector*FirstFaulting APIs are passing

===================Running default===================
------------------- {} -------------------
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorFirstFaulting_Bases_double_ulong() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorFirstFaulting_Bases_long_ulong() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorFirstFaulting_Bases_ulong_ulong() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorFirstFaulting_Indices_float_int() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorFirstFaulting_Indices_int_int() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorFirstFaulting_Indices_uint_int() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorFirstFaulting_Indices_float_uint() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorFirstFaulting_Indices_int_uint() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorFirstFaulting_Indices_uint_uint() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorFirstFaulting_Indices_double_long() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorFirstFaulting_Indices_long_long() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorFirstFaulting_Indices_ulong_long() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorFirstFaulting_Indices_double_ulong() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorFirstFaulting_Indices_long_ulong() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorFirstFaulting_Indices_ulong_ulong() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorByteZeroExtendFirstFaulting_Indices_int_int() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorByteZeroExtendFirstFaulting_Indices_int_uint() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorByteZeroExtendFirstFaulting_Indices_long_long() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorByteZeroExtendFirstFaulting_Indices_long_ulong() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorByteZeroExtendFirstFaulting_Indices_uint_int() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorByteZeroExtendFirstFaulting_Indices_uint_uint() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorByteZeroExtendFirstFaulting_Indices_ulong_long() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorByteZeroExtendFirstFaulting_Indices_ulong_ulong() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorInt16SignExtendFirstFaulting_Indices_int_int() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorInt16SignExtendFirstFaulting_Indices_int_uint() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorInt16SignExtendFirstFaulting_Indices_long_long() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorInt16SignExtendFirstFaulting_Indices_long_ulong() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorInt16SignExtendFirstFaulting_Indices_uint_int() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorInt16SignExtendFirstFaulting_Indices_uint_uint() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorInt16SignExtendFirstFaulting_Indices_ulong_long() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorInt16SignExtendFirstFaulting_Indices_ulong_ulong() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorInt16WithByteOffsetsSignExtendFirstFaulting_offsets_int_int() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorInt16WithByteOffsetsSignExtendFirstFaulting_offsets_int_uint() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorInt16WithByteOffsetsSignExtendFirstFaulting_offsets_long_long() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorInt16WithByteOffsetsSignExtendFirstFaulting_offsets_long_ulong() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorInt16WithByteOffsetsSignExtendFirstFaulting_offsets_uint_int() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorInt16WithByteOffsetsSignExtendFirstFaulting_offsets_uint_uint() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorInt16WithByteOffsetsSignExtendFirstFaulting_offsets_ulong_long() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorInt16WithByteOffsetsSignExtendFirstFaulting_offsets_ulong_ulong() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorInt32SignExtendFirstFaulting_Indices_long_long() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorInt32SignExtendFirstFaulting_Indices_long_ulong() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorInt32SignExtendFirstFaulting_Indices_ulong_long() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorInt32SignExtendFirstFaulting_Indices_ulong_ulong() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorInt32WithByteOffsetsSignExtendFirstFaulting_offsets_long_long() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorInt32WithByteOffsetsSignExtendFirstFaulting_offsets_long_ulong() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorInt32WithByteOffsetsSignExtendFirstFaulting_offsets_ulong_long() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorInt32WithByteOffsetsSignExtendFirstFaulting_offsets_ulong_ulong() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorSByteSignExtendFirstFaulting_Indices_int_int() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorSByteSignExtendFirstFaulting_Indices_int_uint() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorSByteSignExtendFirstFaulting_Indices_long_long() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorSByteSignExtendFirstFaulting_Indices_long_ulong() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorSByteSignExtendFirstFaulting_Indices_uint_int() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorSByteSignExtendFirstFaulting_Indices_uint_uint() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorSByteSignExtendFirstFaulting_Indices_ulong_long() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorSByteSignExtendFirstFaulting_Indices_ulong_ulong() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt16WithByteOffsetsZeroExtendFirstFaulting_offsets_int_int() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt16WithByteOffsetsZeroExtendFirstFaulting_offsets_int_uint() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt16WithByteOffsetsZeroExtendFirstFaulting_offsets_long_long() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt16WithByteOffsetsZeroExtendFirstFaulting_offsets_long_ulong() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt16WithByteOffsetsZeroExtendFirstFaulting_offsets_uint_int() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt16WithByteOffsetsZeroExtendFirstFaulting_offsets_uint_uint() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt16WithByteOffsetsZeroExtendFirstFaulting_offsets_ulong_long() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt16WithByteOffsetsZeroExtendFirstFaulting_offsets_ulong_ulong() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt16ZeroExtendFirstFaulting_Indices_int_int() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt16ZeroExtendFirstFaulting_Indices_int_uint() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt16ZeroExtendFirstFaulting_Indices_long_long() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt16ZeroExtendFirstFaulting_Indices_long_ulong() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt16ZeroExtendFirstFaulting_Indices_uint_int() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt16ZeroExtendFirstFaulting_Indices_uint_uint() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt16ZeroExtendFirstFaulting_Indices_ulong_long() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt16ZeroExtendFirstFaulting_Indices_ulong_ulong() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt32WithByteOffsetsZeroExtendFirstFaulting_offsets_int_int() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt32WithByteOffsetsZeroExtendFirstFaulting_offsets_int_uint() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt32WithByteOffsetsZeroExtendFirstFaulting_offsets_long_long() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt32WithByteOffsetsZeroExtendFirstFaulting_offsets_long_ulong() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt32WithByteOffsetsZeroExtendFirstFaulting_offsets_uint_int() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt32WithByteOffsetsZeroExtendFirstFaulting_offsets_uint_uint() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt32WithByteOffsetsZeroExtendFirstFaulting_offsets_ulong_long() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt32WithByteOffsetsZeroExtendFirstFaulting_offsets_ulong_ulong() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt32ZeroExtendFirstFaulting_Indices_int_int() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt32ZeroExtendFirstFaulting_Indices_int_uint() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt32ZeroExtendFirstFaulting_Indices_long_long() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt32ZeroExtendFirstFaulting_Indices_long_ulong() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt32ZeroExtendFirstFaulting_Indices_uint_int() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt32ZeroExtendFirstFaulting_Indices_uint_uint() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt32ZeroExtendFirstFaulting_Indices_ulong_long() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt32ZeroExtendFirstFaulting_Indices_ulong_ulong() : 13
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorByteZeroExtendFirstFaulting_Bases_long_ulong() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorByteZeroExtendFirstFaulting_Bases_ulong_ulong() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorInt16SignExtendFirstFaulting_Bases_long_ulong() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorInt16SignExtendFirstFaulting_Bases_ulong_ulong() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt16ZeroExtendFirstFaulting_Bases_long_ulong() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt16ZeroExtendFirstFaulting_Bases_ulong_ulong() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt32ZeroExtendFirstFaulting_Bases_long_ulong() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorUInt32ZeroExtendFirstFaulting_Bases_ulong_ulong() : 16
===================Running jitstress===================
------------------- {'JitMinOpts': '1'} -------------------
------------------- {'JitStress': '1'} -------------------
------------------- {'JitStress': '2'} -------------------
------------------- {'JitStress': '1', 'TieredCompilation': '1'} -------------------
------------------- {'JitStress': '2', 'TieredCompilation': '1'} -------------------
------------------- {'TailcallStress': '1'} -------------------
------------------- {'ReadyToRun': '0'} -------------------
===================Running jitstressregs===================
------------------- {'JitStressRegs': '1'} -------------------
------------------- {'JitStressRegs': '2'} -------------------
------------------- {'JitStressRegs': '3'} -------------------
------------------- {'JitStressRegs': '4'} -------------------
------------------- {'JitStressRegs': '8'} -------------------
------------------- {'JitStressRegs': '0x10'} -------------------
------------------- {'JitStressRegs': '0x80'} -------------------
------------------- {'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStressRegs': '0x2000'} -------------------
===================Running jitstress2-jitstressregs===================
------------------- {'JitStress': '2', 'JitStressRegs': '1'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '2'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '3'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '4'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '8'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x10'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x80'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x2000'} -------------------

a74nh · 2024-08-09T11:06:13Z

src\libraries\System.Private.CoreLib\src\System\Runtime\Intrinsics\Arm\Sve.PlatformNotSupported.cs(3703,1): error CS1570: (NETCORE_ENGINEERING_TELEMETRY=Build) XML comment has badly formed XML -- 'Expected an end tag for element 'uint'.'

looks like valid errors from the CI

src/libraries/Common/tests/TestUtilities/System/Buffers/BoundedMemory.Windows.cs

src/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_Arm.cs

amanasifkhalid · 2024-08-12T17:08:24Z

@SwapnilGaikwad #106199 has been merged

Change-Id: Ia064b10db27b63b1b1254c4f478bf11a81aff4b2

src/coreclr/jit/hwintrinsiclistarm64sve.h

JulieLeeMSFT · 2024-08-13T18:31:54Z

@amanasifkhalid, @dotnet/arm64-contrib, please do code review for this last FFR PR.

amanasifkhalid

Sorry to ask you to do this, but could you try uncommenting the ConditionalSelect_FalseOp scenarios like I did in #106349, and re-run the tests you added, please? Just want to make sure that PR can go in cleanly alongside this one.

src/coreclr/jit/hwintrinsiclistarm64sve.h

…er for firstFaulting APIs

amanasifkhalid

LGTM, verified offline that ConditionalSelect_FalseOp works too. Thanks!

JulieLeeMSFT · 2024-08-14T01:22:57Z

This completes our last SVE APIs work for .NET9.

TIHan and others added 24 commits July 2, 2024 12:54

Initial work

d0efc9e

Merge remote-tracking branch 'upstream/main' into sve-ffr-part1

42148fd

FirstFaulting partially works

a7773ac

Added template

76b42bd

Trying to test first-faulting behavior

bb01e37

Using BoundedMemory to test FirstFaulting behavior for LoadVector.

a602b24

Fix size in validation

60d410a

Added more helper functions. Added conditional select tests for LoadV…

aee87d7

…ectorFirstFaulting.

Added first-faulting behavior tests for GatherVectorFirstFaulting

7f3bb3c

Merging with main

d952ff1

Added GetFfr suffix-style APIs

3923946

Fixing GatherVector tests

461b6a3

Formatting

d5b8675

Feedback

07833e3

Merge remote-tracking branch 'upstream/main' into sve-ffr-part1

ce5a9bd

Feedback

05fb46d

Ensure the P/Invokes are blittable

c63f878

Merging

a4533fe

Merge remote-tracking branch 'upstream/main' into sve-ffr-part1

72d1dea

Fix build

6c28927

Remove checking for zeroes after the fault

fb2012e

Added GatherVectorFirstFaultingVectorBases test template, but current…

aca6759

…ly without the FirstFaulting test. Added SveFfrTest template.

Mark GetFfr methods as side-effectful

d781fdc

Add Sve.GatherVectorUInt*ZeroExtendFirstFaulting()

405fad7

ghost added area-System.Runtime.Intrinsics new-api-needs-documentation labels Jul 17, 2024

dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 17, 2024

SwapnilGaikwad added 2 commits August 8, 2024 23:21

Merge main

c32a200

Merge main

5bba48f

a74nh reviewed Aug 9, 2024

View reviewed changes

src/libraries/Common/tests/TestUtilities/System/Buffers/BoundedMemory.Windows.cs Outdated Show resolved Hide resolved

SwapnilGaikwad added 3 commits August 9, 2024 12:56

Fix the formatting of a comment causing build failure

c21c773

Merge main

1e77468

Fix unintentional change

206ae4e

build-analysis bot mentioned this pull request Aug 9, 2024

System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558

Closed

amanasifkhalid reviewed Aug 9, 2024

View reviewed changes

src/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_Arm.cs Show resolved Hide resolved

JulieLeeMSFT assigned SwapnilGaikwad Aug 9, 2024

JulieLeeMSFT added this to the 9.0.0 milestone Aug 9, 2024

SwapnilGaikwad added 2 commits August 13, 2024 15:49

Merge main

4242ec7

Change-Id: Ia064b10db27b63b1b1254c4f478bf11a81aff4b2

Use a template for byte offset

91e8d63

a74nh reviewed Aug 13, 2024

View reviewed changes

src/coreclr/jit/hwintrinsiclistarm64sve.h Outdated Show resolved Hide resolved

Merge main

fb54845

JulieLeeMSFT requested a review from amanasifkhalid August 13, 2024 18:31

amanasifkhalid reviewed Aug 13, 2024

View reviewed changes

src/coreclr/jit/hwintrinsiclistarm64sve.h Outdated Show resolved Hide resolved

SwapnilGaikwad added 2 commits August 13, 2024 22:23

Update HW_Flag_SpecialSideEffectMask to HW_Flag_SpecialSideEffect_Oth…

6737258

…er for firstFaulting APIs

Merge main

81d985f

amanasifkhalid approved these changes Aug 13, 2024

View reviewed changes

amanasifkhalid merged commit f9c0846 into dotnet:main Aug 14, 2024

SwapnilGaikwad deleted the github-firstFaultingGatherVector branch August 14, 2024 09:27

github-actions bot locked and limited conversation to collaborators Sep 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Add Sve.GatherVectorUInt*ZeroExtendFirstFaulting()#105030

Add support for Add Sve.GatherVectorUInt*ZeroExtendFirstFaulting()#105030
amanasifkhalid merged 71 commits intodotnet:mainfrom
SwapnilGaikwad:github-firstFaultingGatherVector

SwapnilGaikwad commented Jul 17, 2024

Uh oh!

ghost commented Jul 17, 2024

Uh oh!

ghost commented Jul 17, 2024

Uh oh!

dotnet-policy-service bot commented Jul 17, 2024

Uh oh!

SwapnilGaikwad commented Aug 8, 2024

Uh oh!

a74nh commented Aug 9, 2024

Uh oh!

Uh oh!

Uh oh!

amanasifkhalid commented Aug 12, 2024

Uh oh!

Uh oh!

JulieLeeMSFT commented Aug 13, 2024

Uh oh!

amanasifkhalid left a comment

Uh oh!

Uh oh!

amanasifkhalid left a comment

Uh oh!

JulieLeeMSFT commented Aug 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

SwapnilGaikwad commented Jul 17, 2024

Uh oh!

ghost commented Jul 17, 2024

Uh oh!

ghost commented Jul 17, 2024

Uh oh!

dotnet-policy-service bot commented Jul 17, 2024

Uh oh!

SwapnilGaikwad commented Aug 8, 2024

Uh oh!

a74nh commented Aug 9, 2024

Uh oh!

Uh oh!

Uh oh!

amanasifkhalid commented Aug 12, 2024

Uh oh!

Uh oh!

JulieLeeMSFT commented Aug 13, 2024

Uh oh!

amanasifkhalid left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

amanasifkhalid left a comment

Choose a reason for hiding this comment

Uh oh!

JulieLeeMSFT commented Aug 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants