Handle possible null in SerialStream.Dispose() on Windows#103671
Closed
omajid wants to merge 1 commit intodotnet:mainfrom
Closed
Handle possible null in SerialStream.Dispose() on Windows#103671omajid wants to merge 1 commit intodotnet:mainfrom
omajid wants to merge 1 commit intodotnet:mainfrom
Conversation
The code expects multiple threads to call it, and it's possible one thread sets `_handle` to null before the second thread enter the block and tries to call `_handle.Close()`.
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-io |
This was referenced Jun 19, 2024
Open
Member
|
Thanks. What is the race condition you're trying to fix? Calling Dispose concurrently with itself is not supported. |
stephentoub
added
the
needs-author-action
Member
|
Closing due to no response. But thanks for trying to improve things here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code expects multiple threads to call it, and it's possible one thread sets
_handleto null before the second thread enter the block and tries to call_handle.Close().