InlineArray's Equals and GetHashCode throw#103612
Merged
AaronRobinsonMSFT merged 5 commits intodotnet:mainfrom Jun 20, 2024
Merged
InlineArray's Equals and GetHashCode throw#103612AaronRobinsonMSFT merged 5 commits intodotnet:mainfrom
InlineArray's Equals and GetHashCode throw#103612AaronRobinsonMSFT merged 5 commits intodotnet:mainfrom
Conversation
The default Equals() and GetHashCode() throw for types marked with InlineArrayAttribute.
AaronRobinsonMSFT
changed the title
InlineArray's Equals and GetHashCode throw
jkotas
reviewed
Jun 18, 2024
...oreclr/nativeaot/System.Private.CoreLib/src/Internal/Runtime/CompilerHelpers/ThrowHelpers.cs
Outdated
Show resolved
Hide resolved
jkotas
approved these changes
Jun 18, 2024
This was referenced Jun 18, 2024
Add test for types where their layout is the same whether InlineArray is provided or not.
AArnott
approved these changes
Jun 19, 2024
This was referenced Jun 19, 2024
Open
lambdageek
approved these changes
Jun 19, 2024
tannergooding
approved these changes
Jun 19, 2024
This was referenced Jun 19, 2024
AaronRobinsonMSFT
added
the
breaking-change
dotnet-policy-service
bot
added
the
needs-breaking-change-doc-created
AaronRobinsonMSFT
removed
the
needs-breaking-change-doc-created
rzikm
pushed a commit
to rzikm/dotnet-runtime
that referenced
this pull request
Jun 24, 2024
* InlineArray's Equals and GetHashCode throw The default Equals() and GetHashCode() throw for types marked with InlineArrayAttribute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default
Equals()andGetHashCode()throwfor types marked with
InlineArrayAttribute.Fixes #96943
See documentation update at dotnet/dotnet-api-docs#10036