Create portable box helper and wrap the thread-local alloc context in a struct#103607
Merged
jkoritzinsky merged 8 commits intodotnet:mainfrom Jun 20, 2024
Merged
Conversation
…odegen is close, but we don't need to be exact as most box operations are inlined anyway
…ode, frame/gc frame chains, etc)
Contributor
|
Tagging subscribers to this area: @mangod9 |
jkotas
reviewed
Jun 18, 2024
Member
|
Arm32 is failing with asserts like: Looks like a problem caused by |
jkotas
reviewed
Jun 18, 2024
This was referenced Jun 18, 2024
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
jkotas
reviewed
Jun 18, 2024
jkotas
approved these changes
Jun 18, 2024
Member
|
cc @elinor-fung for the cDAC change |
This was referenced Jun 19, 2024
Open
elinor-fung
reviewed
Jun 19, 2024
Co-authored-by: Elinor Fung <elfung@microsoft.com>
elinor-fung
approved these changes
Jun 20, 2024
Member
Author
|
/ba-g build failure is linked to a known test failure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a portable box helper and remove the assembly-based one. The codegen is close, but we don't need to be exact as most box operations are inlined anyway
Follow-ups to #103055