Revert "Consolidate <NativeAotSupported definitions (#103273)"#103497
Merged
MichalStrehovsky merged 4 commits intodotnet:mainfrom Jun 15, 2024
Merged
Revert "Consolidate <NativeAotSupported definitions (#103273)"#103497MichalStrehovsky merged 4 commits intodotnet:mainfrom
MichalStrehovsky merged 4 commits intodotnet:mainfrom
Conversation
ghost
added
the
lambdageek
approved these changes
Jun 14, 2024
This was referenced Jun 15, 2024
Open
Member
|
It only requires reverting one file |
am11
added a commit
to am11/runtime
that referenced
this pull request
Jun 15, 2024
Alternative fix for dotnet#103497
Member
Author
|
/ba-g infra timeouts timeouts |
Member
Author
My boss's boss was asking about this last night. Apparently nobody bothered to merge this while I was sleeping. I'll not take any more risks with this right now. |
Member
|
Yea, no rush. Lets unblock the official build then revert the revert. Pretty sure #103508 will fix the issue as I was able to repro it locally. |
am11
added a commit
to am11/runtime
that referenced
this pull request
Jun 15, 2024
…03273)" (dotnet#103497)" This reverts commit 7e9cab2.
am11
added a commit
to am11/runtime
that referenced
this pull request
Jun 15, 2024
Alternative fix for dotnet#103497
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These failures are actually nondeterministic:
https://dnceng.visualstudio.com/internal/_build/results?buildId=2474015&view=results was a clean build.
https://dnceng.visualstudio.com/internal/_build/results?buildId=2474150&view=results after that failed in the MUSL x64 leg the same way I posted in #103469 (seemingly used wrong path to invoke ilc).
Cc @am11 sorry I got to roll this back for now.