Obsolete ServicePointManager 🎉#103456
Merged
MihaZupan merged 2 commits intodotnet:mainfrom Jun 15, 2024
Merged
Conversation
|
Note regarding the |
1 similar comment
|
Note regarding the |
MihaZupan
commented
Jun 13, 2024
|
|
||
| #pragma warning disable SYSLIB0014 // ServicePointManager is obsolete | ||
| _sslStream?.AuthenticateAsServer(_cert, true, (SslProtocols)ServicePointManager.SecurityProtocol, false); | ||
| #pragma warning restore SYSLIB0014 |
Member
Author
There was a problem hiding this comment.
stephentoub
reviewed
Jun 14, 2024
| namespace System.Net | ||
| { | ||
| // NOTE: While this class is not explicitly marked as obsolete, | ||
| // it effectively is by virtue of WebRequest.Create being obsolete. |
Member
There was a problem hiding this comment.
Why haven't we explicitly marked it?
Member
Author
There was a problem hiding this comment.
I believe it was to reduce the noise for anyone still using it without suppressing it at the project level.
They must suppress the warning at least once when creating the request, but not everywhere else they might have plumbed the types through.
This was referenced Jun 14, 2024
rzikm
reviewed
Jun 14, 2024
This was referenced Jun 14, 2024
Closed
This was referenced Jun 17, 2024
This was referenced Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #71836