Bring back JIT support for core Vector64/128/256/512 APIs#103177
Merged
tannergooding merged 1 commit intodotnet:mainfrom Jun 12, 2024
Merged
Bring back JIT support for core Vector64/128/256/512 APIs#103177tannergooding merged 1 commit intodotnet:mainfrom
tannergooding merged 1 commit intodotnet:mainfrom
Conversation
ghost
added
the
area-CodeGen-coreclr
Member
Author
|
CC. @jkotas |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
jkotas
approved these changes
Jun 7, 2024
Member
jkotas
left a comment
jkotas
left a comment
There was a problem hiding this comment.
LGTM. (Somebody from the JIT team should signoff as well.)
tannergooding
force-pushed
the
proto-102275
branch
from
06e35e3 to
7f6c2ed
Compare
Member
Author
|
(Pushed to the wrong branch by accident, it's back to how it was at last approval) |
Member
Author
CC. @EgorBo, since you've reviewed the other PRs |
This was referenced Jun 8, 2024
EgorBo
approved these changes
Jun 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the discussion in #103150, the basic building blocks (
Vector64/128/256/512<T>andVector<T>) should stay intrinsic in the JIT.This doesn't bring back "all" APIs, but rather the core ones that are expected to see the heaviest usage. In general, the rule I followed on deciding what to bring back vs not was that if it was a general API that was a 1-to-1 forward to another intrinsic and didn't get any other specialization it was fine to leave in managed
So while it brings back ones like
get_ZeroandAs, it doesn't bring backAnd(forwards toop_BitwiseAddition),Add(forwards toop_Addition), orLoad(forwards toLoadUnsafe).As per the discussion,
Vector2,Vector3,Vector4,Quaternion, andPlaneremain implemented in managed.