Allow TypePreserve info to be applied multiple times#103140
Merged
jtschuster merged 4 commits intodotnet:mainfrom Jun 12, 2024
Merged
Allow TypePreserve info to be applied multiple times#103140jtschuster merged 4 commits intodotnet:mainfrom
jtschuster merged 4 commits intodotnet:mainfrom
Conversation
ghost
added
the
area-Tools-ILLink
dotnet-policy-service
bot
added
the
linkable-framework
Contributor
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas |
sbomer
reviewed
Jun 6, 2024
Member
sbomer
left a comment
sbomer
left a comment
There was a problem hiding this comment.
Product change LGTM, but had a question about the test.
...ools/illink/test/Mono.Linker.Tests.Cases/CommandLine/Dependencies/CustomApplyPreserveStep.cs
Show resolved
Hide resolved
This was referenced Jun 7, 2024
Open
This was referenced Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #103115
Allows TypePreserve info to be applied multiple times. Pending preserve items may not be processed when the preserve info is applied, and the preserve info may be applied twice (in ProcessMarkedPending and ProcessType). If the preserve has already been applied in these cases, we will just return early rather than throwing an exception.
Adds a test that applies a preserve on an otherwise unreferenced type