Implement JsonSerializerOptions.RespectRequiredConstructorParameters#103096
Merged
eiriktsarpalis merged 4 commits intodotnet:mainfrom Jun 6, 2024
Merged
Implement JsonSerializerOptions.RespectRequiredConstructorParameters#103096eiriktsarpalis merged 4 commits intodotnet:mainfrom
JsonSerializerOptions.RespectRequiredConstructorParameters#103096eiriktsarpalis merged 4 commits intodotnet:mainfrom
Conversation
ghost
added
|
Note regarding the |
1 similar comment
|
Note regarding the |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
eiriktsarpalis
commented
Jun 5, 2024
| Debug.Assert(parent.PropertyCache != null); | ||
|
|
||
| // Soft cut-off length - once message becomes longer than that we won't be adding more elements | ||
| const int CutOffLength = 50; |
Member
Author
There was a problem hiding this comment.
Because I've updated the error message so that property names are wrapped with single quotes, I'm also increasing the cutoff so that roughly speaking the same number of properties are being displayed.
This was referenced Jun 6, 2024
Closed
jozkee
reviewed
Jun 6, 2024
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonParameterInfo.cs
Show resolved
Hide resolved
jozkee
reviewed
Jun 6, 2024
...braries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs
Outdated
Show resolved
Hide resolved
…onstructorTests.ParameterMatching.cs
krwq
reviewed
Jun 6, 2024
krwq
reviewed
Jun 6, 2024
src/libraries/System.Text.Json/src/System/Text/Json/AppContextSwitchHelper.cs
Show resolved
Hide resolved
eiriktsarpalis
commented
Jun 6, 2024
...braries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs
Show resolved
Hide resolved
…onstructorTests.ParameterMatching.cs
eiriktsarpalis
commented
Jun 6, 2024
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/OptionsTests.cs
Outdated
Show resolved
Hide resolved
…rialization/OptionsTests.cs
krwq
reviewed
Jun 6, 2024
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonPropertyInfo.cs
Show resolved
Hide resolved
krwq
reviewed
Jun 6, 2024
...braries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs
Show resolved
Hide resolved
krwq
approved these changes
Jun 6, 2024
Member
krwq
left a comment
krwq
left a comment
There was a problem hiding this comment.
LGTM assuming comments are addressed
This was referenced Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #100075