fix NetworkInterface properties on Windows#102900
Merged
wfurt merged 1 commit intodotnet:mainfrom May 31, 2024
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/ncl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #101710
It is regression from #100824. It did replaced original flags with
IncludeAllInterfaces. But the interaction to include all interfaces does not guarantied that all of them would have all properties populated.Strangely, on my dev box it would still show gateway even with the change but some Windows instances would not.
So this change brings all flags together and OR them with the new one to get superset.
Tested on system @Junjun-zhao kindly provided.