Add support for exported types in illink XML formats#102487
Merged
MichalStrehovsky merged 1 commit intodotnet:mainfrom May 22, 2024
Merged
Add support for exported types in illink XML formats#102487MichalStrehovsky merged 1 commit intodotnet:mainfrom
MichalStrehovsky merged 1 commit intodotnet:mainfrom
Conversation
Addresses the TODO in the native AOT port. Ran into inability of rooting things from mscorlib with the illink XML format on native AOT so decided to fix the TODO. (It was possible to work around with `Type.GetType` (that's a supported pattern) or rd.xml, but this should work with the descriptors too.)
ghost
added
the
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
| // TODO: Process exported types | ||
| MetadataType? type = CecilCompatibleTypeParser.GetType(assembly, fullname); | ||
|
|
||
| TypeDesc? type = CecilCompatibleTypeParser.GetType(assembly, fullname); |
Member
Author
There was a problem hiding this comment.
This was already returning a resolved type, so exported types worked, but we "forgot" we got to the type through a forwarder and didn't preserve it. The newly added type.Module != assembly is basically "was this a forwarder?".
This was referenced May 21, 2024
sbomer
approved these changes
May 21, 2024
steveharter
pushed a commit
to steveharter/runtime
that referenced
this pull request
May 28, 2024
Addresses the TODO in the native AOT port. Ran into inability of rooting things from mscorlib with the illink XML format on native AOT so decided to fix the TODO. (It was possible to work around with `Type.GetType` (that's a supported pattern) or rd.xml, but this should work with the descriptors too.)
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
Addresses the TODO in the native AOT port. Ran into inability of rooting things from mscorlib with the illink XML format on native AOT so decided to fix the TODO. (It was possible to work around with `Type.GetType` (that's a supported pattern) or rd.xml, but this should work with the descriptors too.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the TODO in the native AOT port.
Ran into inability of rooting things from mscorlib with the illink XML format on native AOT so decided to fix the TODO.
(It was possible to work around with
Type.GetType(that's a supported pattern) or rd.xml, but this should work with the descriptors too.)Cc @dotnet/ilc-contrib