Add `SetEntryAssembly()` API to `System.Reflection` by ivdiazsa · Pull Request #102271 · dotnet/runtime

ivdiazsa · 2024-05-15T16:52:32Z

Implements the API proposal detailed and approved in issue #101616. This new API will allow developers to change the entry assembly of their .NET apps on the fly, should they require it. One important scenario is app launchers. With the usage of this API, then functions like GetEntryAssembly() will return the right value, and thus we will be able to ensure the information is consistent and correct.

ghost · 2024-05-15T16:52:38Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-05-15T16:53:04Z

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

src/coreclr/System.Private.CoreLib/CompatibilitySuppressions.xml

src/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs

"s_overriddenEntryAssembly", added an API doc to SetEntryAssembly(), added validation for it to be a Runtime Assembly, and changed the type to allow a null entry assembly.

...ries/System.Configuration.ConfigurationManager/tests/System/Configuration/CustomHostTests.cs

src/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs

jkotas · 2024-05-15T20:26:07Z

This needs some tests (

runtime/src/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs

Line 182 in 1ee61b8

}

is a good place to add them)

src/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs

…embly.cs Co-authored-by: Jan Kotas <jkotas@microsoft.com>

ivdiazsa · 2024-05-16T18:18:33Z

Seems I got an import wrong. Will look into it.

...ries/System.Configuration.ConfigurationManager/tests/System/Configuration/CustomHostTests.cs

...ics.TraceSource/tests/System.Diagnostics.TraceSource.Tests/DefaultTraceListenerClassTests.cs

fixed the issue with the remote executor.

src/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs

src/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

jkotas

LGTM. Thank you!

ivdiazsa · 2024-05-17T17:14:44Z

I wonder where that trailing whitespace came from... Let me fix it so we can merge. Thanks a lot for your guidance with this @jkotas!

…analyzers.

ivdiazsa · 2024-05-17T17:32:13Z

Might be just my ptsd of breaking the outerloop with a PR I did last year, so I'll kick off an outerloop run just to be safe we can merge this.

ivdiazsa · 2024-05-17T17:32:23Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2024-05-17T17:32:35Z

Azure Pipelines successfully started running 1 pipeline(s).

…re not passing parameters to it.

* Trying out JanK's approach to override the entry assembly... * Fixed what was missing for this reflection scenario to work correctly. * Reverted the compatibility suppressions added by the build script. * Forgot to revert also the nativeaot part of the suppressions. * Addressed PR comments: Updated the tests to use the new "s_overriddenEntryAssembly", added an API doc to SetEntryAssembly(), added validation for it to be a Runtime Assembly, and changed the type to allow a null entry assembly. * Added tests and addressed more comments on the PR. * Added exception test case for SetEntryAssembly, and wrapped all its test cases in a RemoteExecutor.Invoke() call, in order to avoid potentially interferring with the GetEntryAssembly tests. * Update src/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs Co-authored-by: Jan Kotas <jkotas@microsoft.com> * Refactored further the tests that force a null entry assembly, and fixed the issue with the remote executor. * Apply Jan's suggestions Co-authored-by: Jan Kotas <jkotas@microsoft.com> * Fixed a sneaky trailing whitespace that was messing up with the code analyzers. * Changed ConditionalTheory to ConditionalFact in the tests because we're not passing parameters to it. * Disabled building the CustomHostTests test file when .NET Framework --------- Co-authored-by: Jan Kotas <jkotas@microsoft.com>

ivdiazsa added 2 commits April 19, 2024 11:06

Trying out JanK's approach to override the entry assembly...

cd6bee0

Fixed what was missing for this reflection scenario to work correctly.

440b1a2

ivdiazsa added the area-System.Reflection label May 15, 2024

ivdiazsa added this to the 9.0.0 milestone May 15, 2024

ivdiazsa requested review from fanyang-mono, jkotas, kg, lambdageek and steveisok May 15, 2024 16:52

ivdiazsa requested a review from MichalStrehovsky as a code owner May 15, 2024 16:52

ghost added the new-api-needs-documentation label May 15, 2024

dotnet-policy-service bot assigned ivdiazsa May 15, 2024

kg reviewed May 15, 2024

View reviewed changes

src/coreclr/System.Private.CoreLib/CompatibilitySuppressions.xml Outdated Show resolved Hide resolved

jkotas reviewed May 15, 2024

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs Outdated Show resolved Hide resolved

jkotas reviewed May 15, 2024

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs Outdated Show resolved Hide resolved

jkotas reviewed May 15, 2024

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs Outdated Show resolved Hide resolved

MichalStrehovsky reviewed May 15, 2024

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs Outdated Show resolved Hide resolved

ivdiazsa added 4 commits May 15, 2024 11:35

Merge branch 'main' into managed-contract-facade

3bea613

Reverted the compatibility suppressions added by the build script.

7fc6c77

Forgot to revert also the nativeaot part of the suppressions.

2caf450

Addressed PR comments: Updated the tests to use the new

a2f86a5

"s_overriddenEntryAssembly", added an API doc to SetEntryAssembly(), added validation for it to be a Runtime Assembly, and changed the type to allow a null entry assembly.

jkotas reviewed May 15, 2024

View reviewed changes

...ries/System.Configuration.ConfigurationManager/tests/System/Configuration/CustomHostTests.cs Outdated Show resolved Hide resolved

jkotas reviewed May 15, 2024

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs Outdated Show resolved Hide resolved

jkotas reviewed May 15, 2024

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs Show resolved Hide resolved

Added tests and addressed more comments on the PR.

cc6a5fa

jkotas reviewed May 15, 2024

View reviewed changes

src/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs Show resolved Hide resolved

jkotas reviewed May 15, 2024

View reviewed changes

src/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs Outdated Show resolved Hide resolved

build-analysis bot mentioned this pull request May 16, 2024

NativeAOT legs timing out in CI #102239

Closed

Update src/libraries/System.Private.CoreLib/src/System/Reflection/Ass…

d574dad

…embly.cs Co-authored-by: Jan Kotas <jkotas@microsoft.com>

jkotas reviewed May 16, 2024

View reviewed changes

...ries/System.Configuration.ConfigurationManager/tests/System/Configuration/CustomHostTests.cs Outdated Show resolved Hide resolved

jkotas reviewed May 16, 2024

View reviewed changes

...ics.TraceSource/tests/System.Diagnostics.TraceSource.Tests/DefaultTraceListenerClassTests.cs Outdated Show resolved Hide resolved

Refactored further the tests that force a null entry assembly, and

4d02c7a

fixed the issue with the remote executor.

jkotas reviewed May 17, 2024

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs Outdated Show resolved Hide resolved

jkotas reviewed May 17, 2024

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs Outdated Show resolved Hide resolved

jkotas reviewed May 17, 2024

View reviewed changes

src/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs Outdated Show resolved Hide resolved

jkotas reviewed May 17, 2024

View reviewed changes

src/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs Outdated Show resolved Hide resolved

Apply Jan's suggestions

aac56b3

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

jkotas approved these changes May 17, 2024

View reviewed changes

Fixed a sneaky trailing whitespace that was messing up with the code …

ccf2ec6

…analyzers.

Changed ConditionalTheory to ConditionalFact in the tests because we'…

b06df49

…re not passing parameters to it.

This was referenced May 17, 2024

[wasm][AOT][net8.0] emcc : error - received SIGKILL (-9) #89402

Open

Failed test: baseservices/exceptions/unhandled/unhandledTester/unhandledTester #100495

Closed

Disabled building the CustomHostTests test file when .NET Framework

671c2f1

This was referenced May 21, 2024

Abort on mono in SwiftErrorHandling #102478

Closed

SupportedLinuxPlatforms_IsSupportedIsTrue failed in CI #102479

Closed

ivdiazsa merged commit 362a95d into dotnet:main May 21, 2024

jkotas mentioned this pull request May 29, 2024

[API Proposal]: Assembly.SetEntryAssembly() #101616

Closed

elinor-fung mentioned this pull request Jun 7, 2024

No way to set the .NET entry assembly from unmanaged host? Also, documentation seems to be wrong/unclear. #94139

Closed

jkotas mentioned this pull request Jun 14, 2024

Add ability to output a shim .exe + .dll for an application (for WinRT activation) #103451

Closed

steveisok mentioned this pull request Jun 19, 2024

[release/8.0-staging] Add non-public SetEntryAssembly() API to System.Reflection #103726

Merged

github-actions bot locked and limited conversation to collaborators Jun 21, 2024

Conversation

ivdiazsa commented May 15, 2024

Uh oh!

ghost commented May 15, 2024

Uh oh!

dotnet-policy-service bot commented May 15, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkotas commented May 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ivdiazsa commented May 16, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

ivdiazsa commented May 17, 2024

Uh oh!

ivdiazsa commented May 17, 2024

Uh oh!

ivdiazsa commented May 17, 2024

Uh oh!

azure-pipelines bot commented May 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

jkotas commented May 15, 2024 •

edited

Loading