[cdac] Remove Try versions of ReadGlobal* on target#102230
Merged
elinor-fung merged 1 commit intodotnet:mainfrom May 15, 2024
Merged
[cdac] Remove Try versions of ReadGlobal* on target#102230elinor-fung merged 1 commit intodotnet:mainfrom
elinor-fung merged 1 commit intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @tommcdon |
AaronRobinsonMSFT
approved these changes
May 14, 2024
Member
AaronRobinsonMSFT
left a comment
AaronRobinsonMSFT
left a comment
There was a problem hiding this comment.
LGTM. Thanks.
Is it appropriate to add this decision to a design document?
lambdageek
approved these changes
May 15, 2024
This was referenced May 15, 2024
Member
Author
I think it is a bit lower level than I'd put in a design document. I'll put it in header comments for Target and SOSDacImpl in my next change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slight follow-up from #101994 (comment)
We settled on keeping the C# side throwing and wrapping the COM API implementations in a try/catch.
Remove
Target.TryReadGlobal*and leave only the throwing versions.cc @lambdageek